Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: custom deleters rock. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 2cec72d37c399fbaeae723f83b4fe5d3e3ebcfca..5f48dad8c46ddaafa2a934b1ff2beffd37dd753a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -10,6 +10,7 @@
#include "content/child/appcache/appcache_dispatcher.h"
#include "content/child/quota_dispatcher.h"
#include "content/child/request_extra_data.h"
+#include "content/common/frame_messages.h"
#include "content/common/socket_stream_handle_data.h"
#include "content/common/swapped_out_messages.h"
#include "content/common/view_messages.h"
@@ -72,6 +73,13 @@ using webkit_glue::WebURLResponseExtraDataImpl;
namespace content {
+namespace {
+
+typedef std::map<WebKit::WebFrame*, RenderFrameImpl*> FrameMap;
+base::LazyInstance<FrameMap> g_child_frame_map = LAZY_INSTANCE_INITIALIZER;
+
+} // namespace
+
static RenderFrameImpl* (*g_create_render_frame_impl)(RenderViewImpl*, int32) =
NULL;
@@ -80,13 +88,10 @@ RenderFrameImpl* RenderFrameImpl::Create(RenderViewImpl* render_view,
int32 routing_id) {
DCHECK(routing_id != MSG_ROUTING_NONE);
- RenderFrameImpl* render_frame = NULL;
if (g_create_render_frame_impl)
- render_frame = g_create_render_frame_impl(render_view, routing_id);
+ return g_create_render_frame_impl(render_view, routing_id);
else
- render_frame = new RenderFrameImpl(render_view, routing_id);
-
- return render_frame;
+ return new RenderFrameImpl(render_view, routing_id);
}
// static
@@ -217,11 +222,28 @@ void RenderFrameImpl::didAccessInitialDocument(WebKit::WebFrame* frame) {
render_view_->didAccessInitialDocument(frame);
}
-void RenderFrameImpl::didCreateFrame(WebKit::WebFrame* parent,
- WebKit::WebFrame* child) {
- render_view_->Send(new ViewHostMsg_FrameAttached(
- render_view_->GetRoutingID(), parent->identifier(), child->identifier(),
- UTF16ToUTF8(child->assignedName())));
+WebKit::WebFrame* RenderFrameImpl::createChildFrame(
+ WebKit::WebFrame* parent,
+ const WebKit::WebString& name) {
+ RenderFrameImpl* child_render_frame = this;
+ long long child_frame_identifier = WebFrame::generateEmbedderIdentifier();
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess)) {
+ // Synchronously notify the browser of a child frame creation to get the
+ // routing_id for the RenderFrame.
+ int routing_id;
+ Send(new FrameHostMsg_CreateChildFrame(GetRoutingID(),
+ parent->identifier(),
+ child_frame_identifier,
+ UTF16ToUTF8(name),
+ &routing_id));
+ child_render_frame = RenderFrameImpl::Create(render_view_, routing_id);
+ }
+
+ WebKit::WebFrame* web_frame = WebFrame::create(child_render_frame,
+ child_frame_identifier);
+ g_child_frame_map.Get().insert(std::make_pair(web_frame, child_render_frame));
+
+ return web_frame;
}
void RenderFrameImpl::didDisownOpener(WebKit::WebFrame* frame) {
@@ -245,13 +267,22 @@ void RenderFrameImpl::frameDetached(WebKit::WebFrame* frame) {
if (frame->parent())
parent_frame_id = frame->parent()->identifier();
- render_view_->Send(new ViewHostMsg_FrameDetached(render_view_->GetRoutingID(),
- parent_frame_id,
- frame->identifier()));
+ render_view_->Send(new FrameHostMsg_Detach(GetRoutingID(), parent_frame_id,
+ frame->identifier()));
// Call back to RenderViewImpl for observers to be notified.
// TODO(nasko): Remove once we have RenderFrameObserver.
render_view_->frameDetached(frame);
+
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess)) {
+ FrameMap::iterator it = g_child_frame_map.Get().find(frame);
+ DCHECK(it != g_child_frame_map.Get().end());
+ DCHECK_EQ(it->second, this);
+ delete it->second;
+ g_child_frame_map.Get().erase(it);
+ }
+
+ frame->close();
}
void RenderFrameImpl::willClose(WebKit::WebFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698