Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: content/browser/renderer_host/frame_tree_unittest.cc

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: custom deleters rock. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/frame_tree_unittest.cc
diff --git a/content/browser/renderer_host/frame_tree_unittest.cc b/content/browser/renderer_host/frame_tree_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c733d918c41fa980b1f046f5546d92c3b6f228b7
--- /dev/null
+++ b/content/browser/renderer_host/frame_tree_unittest.cc
@@ -0,0 +1,105 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/renderer_host/frame_tree.h"
+
+#include "base/run_loop.h"
+#include "content/browser/renderer_host/render_frame_host_impl.h"
+#include "content/public/test/mock_render_process_host.h"
+#include "content/public/test/test_browser_context.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "content/public/test/test_renderer_host.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+namespace {
+
+class FrameTreeTest : public RenderViewHostTestHarness {
+};
+
+// This test asserts the shape of the frame tree is correct, based on incoming
+// frame attached/detached messages.
+TEST_F(FrameTreeTest, FrameTreeShape) {
+ FrameTree frame_tree;
+ std::string no_children_node("no children node");
+ std::string deep_subtree("node with deep subtree");
+
+ // Ensure the top-level node of the FrameTree is initalized by simulating a
+ // main frame swap here.
+ RenderFrameHostImpl render_frame_host(process(), &frame_tree, 5, false);
+ frame_tree.SwapMainFrame(&render_frame_host);
+ frame_tree.OnFirstNavigationAfterSwap(5);
+
+ // Let's send a series of messages for frame attached and build the
+ // frame tree.
+ frame_tree.AddFrame(14, 5, 14, std::string());
+ frame_tree.AddFrame(15, 5, 15, std::string());
+ frame_tree.AddFrame(16, 5, 16, std::string());
+
+ frame_tree.AddFrame(244, 14, 244, std::string());
+ frame_tree.AddFrame(245, 14, 245, std::string());
+
+ frame_tree.AddFrame(255, 15, 255, no_children_node);
+
+ frame_tree.AddFrame(264, 16, 264, std::string());
+ frame_tree.AddFrame(265, 16, 265, std::string());
+ frame_tree.AddFrame(266, 16, 266, std::string());
+ frame_tree.AddFrame(267, 16, 267, deep_subtree);
+ frame_tree.AddFrame(268, 16, 268, std::string());
+
+ frame_tree.AddFrame(365, 267, 365, std::string());
+ frame_tree.AddFrame(455, 365, 455, std::string());
+ frame_tree.AddFrame(555, 455, 555, std::string());
+ frame_tree.AddFrame(655, 555, 655, std::string());
+
+ // Now, verify the tree structure is as expected.
+ FrameTreeNode* root = frame_tree.GetRootForTesting();
+ EXPECT_EQ(5, root->frame_id());
+ EXPECT_EQ(3UL, root->child_count());
+
+ EXPECT_EQ(2UL, root->child_at(0)->child_count());
+ EXPECT_EQ(0UL, root->child_at(0)->child_at(0)->child_count());
+ EXPECT_EQ(0UL, root->child_at(0)->child_at(1)->child_count());
+
+ EXPECT_EQ(1UL, root->child_at(1)->child_count());
+ EXPECT_EQ(0UL, root->child_at(1)->child_at(0)->child_count());
+ EXPECT_STREQ(no_children_node.c_str(),
+ root->child_at(1)->child_at(0)->frame_name().c_str());
+
+ EXPECT_EQ(5UL, root->child_at(2)->child_count());
+ EXPECT_EQ(0UL, root->child_at(2)->child_at(0)->child_count());
+ EXPECT_EQ(0UL, root->child_at(2)->child_at(1)->child_count());
+ EXPECT_EQ(0UL, root->child_at(2)->child_at(2)->child_count());
+ EXPECT_EQ(1UL, root->child_at(2)->child_at(3)->child_count());
+ EXPECT_STREQ(deep_subtree.c_str(),
+ root->child_at(2)->child_at(3)->frame_name().c_str());
+ EXPECT_EQ(0UL, root->child_at(2)->child_at(4)->child_count());
+
+ FrameTreeNode* deep_tree = root->child_at(2)->child_at(3)->child_at(0);
+ EXPECT_EQ(365, deep_tree->frame_id());
+ EXPECT_EQ(1UL, deep_tree->child_count());
+ EXPECT_EQ(455, deep_tree->child_at(0)->frame_id());
+ EXPECT_EQ(1UL, deep_tree->child_at(0)->child_count());
+ EXPECT_EQ(555, deep_tree->child_at(0)->child_at(0)->frame_id());
+ EXPECT_EQ(1UL, deep_tree->child_at(0)->child_at(0)->child_count());
+ EXPECT_EQ(655, deep_tree->child_at(0)->child_at(0)->child_at(0)->frame_id());
+ EXPECT_EQ(0UL,
+ deep_tree->child_at(0)->child_at(0)->child_at(0)->child_count());
+
+ // Test removing of nodes.
+ frame_tree.RemoveFrame(555, 655);
+ EXPECT_EQ(0UL, deep_tree->child_at(0)->child_at(0)->child_count());
+
+ frame_tree.RemoveFrame(16, 265);
+ EXPECT_EQ(4UL, root->child_at(2)->child_count());
+
+ frame_tree.RemoveFrame(5, 15);
+ EXPECT_EQ(2UL, root->child_count());
+
+ // Drop the main frame to avoid a UaF.
+ frame_tree.SwapMainFrame(NULL);
+}
+
+} // namespace
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698