content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase and add some comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | content/common/frame_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index 8e324266a609dd29bfe3f57b554dd0c1ffca8f67..8ad1f71ecbb76b46355d69fa4f4b5b25f83ca2bc 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -224,7 +224,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, FrameTree) {

WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());

RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(

wc->GetRenderViewHost());

- FrameTreeNode* root = wc->GetFrameTreeRootForTesting();

+ FrameTreeNode* root = wc->GetFrameTree()->GetRootForTesting();

// Check that the root node is properly created with the frame id of the

// initial navigation.

@@ -246,7 +246,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, FrameTree) {

// tree in the browser process.

NavigateToURL(shell(), embedded_test_server()->GetURL("/title1.html"));

- root = wc->GetFrameTreeRootForTesting();

+ root = wc->GetFrameTree()->GetRootForTesting();

EXPECT_EQ(0UL, root->child_count());

EXPECT_EQ(std::string(), root->frame_name());

EXPECT_EQ(rvh->main_frame_id(), root->frame_id());