content/browser/renderer_host/render_view_host_browsertest.cc - Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_browsertest.cc

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase and add some comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_frame_message_filter.h ('K') | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_browsertest.cc

diff --git a/content/browser/renderer_host/render_view_host_browsertest.cc b/content/browser/renderer_host/render_view_host_browsertest.cc

index 20fec727501c3898a8483d2ea3ecb009e05ae99b..386ff521afb540d78f8178688d01a4226f2cfc5f 100644

--- a/content/browser/renderer_host/render_view_host_browsertest.cc

+++ b/content/browser/renderer_host/render_view_host_browsertest.cc

@@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostTest, BasicRenderFrameHost) {

RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(

shell()->web_contents()->GetRenderViewHost());

- EXPECT_TRUE(rvh->main_render_frame_host_.get());

+ EXPECT_TRUE(rvh->main_render_frame_host());

ShellAddedObserver new_shell_observer;

EXPECT_TRUE(ExecuteScript(shell()->web_contents(), "window.open();"));

@@ -110,9 +110,9 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostTest, BasicRenderFrameHost) {

RenderViewHostImpl* new_rvh = static_cast<RenderViewHostImpl*>(

new_shell->web_contents()->GetRenderViewHost());

- EXPECT_TRUE(new_rvh->main_render_frame_host_.get());

- EXPECT_NE(rvh->main_render_frame_host_->routing_id(),

- new_rvh->main_render_frame_host_->routing_id());

+ EXPECT_TRUE(new_rvh->main_render_frame_host());

+ EXPECT_NE(rvh->main_render_frame_host()->routing_id(),

+ new_rvh->main_render_frame_host()->routing_id());

}

} // namespace content