Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: notify observers regardless of flag Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index e6e8e680e3ad682dd898751c77fc2f991cb62f90..79c05e4d43d0903e6b76e929841ece193b3d5d5c 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -15,9 +15,9 @@
#include "base/observer_list.h"
#include "base/process/process.h"
#include "base/values.h"
+#include "content/browser/renderer_host/frame_tree.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_delegate.h"
-#include "content/browser/web_contents/frame_tree_node.h"
#include "content/browser/web_contents/navigation_controller_impl.h"
#include "content/browser/web_contents/render_view_host_manager.h"
#include "content/common/content_export.h"
@@ -203,10 +203,6 @@ class CONTENT_EXPORT WebContentsImpl
void DragSourceMovedTo(int client_x, int client_y,
int screen_x, int screen_y);
- FrameTreeNode* GetFrameTreeRootForTesting() {
- return frame_tree_root_.get();
- }
-
// WebContents ------------------------------------------------------
virtual WebContentsDelegate* GetDelegate() OVERRIDE;
virtual void SetDelegate(WebContentsDelegate* delegate) OVERRIDE;
@@ -466,6 +462,7 @@ class CONTENT_EXPORT WebContentsImpl
const MediaResponseCallback& callback) OVERRIDE;
virtual SessionStorageNamespace* GetSessionStorageNamespace(
SiteInstance* instance) OVERRIDE;
+ virtual FrameTree* GetFrameTree() OVERRIDE;
// RenderWidgetHostDelegate --------------------------------------------------
@@ -636,10 +633,6 @@ class CONTENT_EXPORT WebContentsImpl
const std::vector<gfx::Size>& original_bitmap_sizes);
void OnUpdateFaviconURL(int32 page_id,
const std::vector<FaviconURL>& candidates);
- void OnFrameAttached(int64 parent_frame_id,
- int64 frame_id,
- const std::string& frame_name);
- void OnFrameDetached(int64 parent_frame_id, int64 frame_id);
void OnMediaNotification(int64 player_cookie,
bool has_video,
@@ -752,8 +745,6 @@ class CONTENT_EXPORT WebContentsImpl
RenderViewHostImpl* GetRenderViewHostImpl();
- FrameTreeNode* FindFrameTreeNodeByID(int64 frame_id);
-
// Removes browser plugin embedder if there is one.
void RemoveBrowserPluginEmbedder();
@@ -766,6 +757,8 @@ class CONTENT_EXPORT WebContentsImpl
// Helper function to invoke WebContentsDelegate::GetSizeForNewRenderView().
gfx::Size GetSizeForNewRenderView() const;
+ void OnFrameRemoved(int64 frame_id);
+
// Data for core operation ---------------------------------------------------
// Delegate for notifying our owner about stuff. Not owned by us.
@@ -821,6 +814,9 @@ class CONTENT_EXPORT WebContentsImpl
// Manages creation and swapping of render views.
RenderViewHostManager render_manager_;
+ // The frame tree structure of the current page.
+ FrameTree frame_tree_;
+
#if defined(OS_ANDROID)
// Manages injecting Java objects into all RenderViewHosts associated with
// this WebContentsImpl.
@@ -876,9 +872,6 @@ class CONTENT_EXPORT WebContentsImpl
// True if this is a secure page which displayed insecure content.
bool displayed_insecure_content_;
- // The frame tree structure of the current page.
- scoped_ptr<FrameTreeNode> frame_tree_root_;
-
// Data for misc internal state ----------------------------------------------
// When > 0, the WebContents is currently being captured (e.g., for
« no previous file with comments | « content/browser/web_contents/render_view_host_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698