Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: content/common/frame_messages.h

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unittests. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard.
7
8 #include "content/common/content_export.h"
9 #include "ipc/ipc_message_macros.h"
10
11 #undef IPC_MESSAGE_EXPORT
12 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT
13
14 #define IPC_MESSAGE_START FrameMsgStart
15
16 // Sent by the renderer when a child frame is created in the render. The
Charlie Reis 2013/09/27 19:19:21 nit: in the renderer.
awong 2013/09/27 20:50:09 Done.
17 // |parent_frame_id| and |frame_id| are NOT routing ids. They are
18 // render-allocated identifiers used for tracking a frame's creation.
Charlie Reis 2013/09/27 19:19:21 renderer-allocated
awong 2013/09/27 20:50:09 Done.
19 //
20 // Each of these messages will have a corresponding FrameHostMsg_Detach message
21 // sent when the frame is detached from the DOM.
22 //
23 // TOOD(ajwong): replace parent_render_frame_id and frame_id with just the
24 // routing ids.
25 IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame,
26 int32 /* parent_render_frame_id */,
27 int64 /* parent_frame_id */,
28 int64 /* frame_id */,
29 std::string /* frame_name */,
30 int /* new_render_frame_id */)
31
32 // Sent by the renderer to the parent frame when a child frame is detached
Charlie Reis 2013/09/27 19:19:21 nit: parent RenderFrameHost? (what's the parent?)
awong 2013/09/27 20:50:09 Done.
33 // from the DOM.
34 IPC_MESSAGE_ROUTED2(FrameHostMsg_Detach,
35 int64 /* parent_frame_id */,
36 int64 /* frame_id */)
37
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698