content/common/frame_messages.h - Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/frame_messages.h

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase and add some comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for interacting with frames.

	6 // Multiply-included message file, hence no include guard.

	7

	8 #include "content/common/content_export.h"

	9 #include "ipc/ipc_message_macros.h"

	10

	11 #undef IPC_MESSAGE_EXPORT

	12 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

	13

	14 #define IPC_MESSAGE_START FrameMsgStart

	15

	16 // Similar to ViewHostMsg_CreateWindow, except used for sub-frames like

	17 // and <iframe>.
	nasko 2013/09/11 22:26:24 nit: "an" instead of "and"? nit: "an" instead of "and"? awong 2013/09/21 01:19:56 Done. Show quoted text On 2013/09/11 22:26:24, nasko wrote: > nit: "an" instead of "and"? Done.
	18 //

	19 // TODO(ajwong): Remove ViewHostMsg_FrameAttached once a RenderFrame is

	20 // guaranteed to be created per WebCore::Frame, and WebCore::identifier() has

	21 // been replaced by.
	nasko 2013/09/11 22:26:24 Replaced by what? Replaced by what? awong 2013/09/21 01:19:56 Done. Show quoted text On 2013/09/11 22:26:24, nasko wrote: > Replaced by what? Done.
	22 IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame,

	23 int /* parent_render_frame_id */,
	nasko 2013/09/11 22:26:24 Would it help to be explicit and use int32? I know Would it help to be explicit and use int32? I know they are equivalent, but it doesn't hurt IMHO. awong 2013/09/21 01:19:56 sure. Show quoted text On 2013/09/11 22:26:24, nasko wrote: > Would it help to be explicit and use int32? I know they are equivalent, but it > doesn't hurt IMHO. sure.
	24 int64 /* parent_frame_id */,

	25 int64 /* frame_id */,

	26 std::string /* frame_name */,

	27 int /* new_render_frame_id */)

	28

	29 // TODO(ajwong): Remove ViewHostMsg_FrameDetached once a RenderFrame is

	30 // guaranteed to be created per WebCore::Frame.

	31 IPC_MESSAGE_ROUTED2(FrameHostMsg_Detach,

	32 int64 /* parent_frame_id */,

	33 int64 /* frame_id */)

	34

OLD	NEW