Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2384083005: Revert of mus: Use TooltipManagerAura in NativeWidgetMus. (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 2 months ago
Reviewers:
jonross, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mus: Use TooltipManagerAura in NativeWidgetMus. (patchset #9 id:160001 of https://codereview.chromium.org/2379073003/ ) Reason for revert: sky@ reports that TooltipControllerCaptureTest.Capture is failing on local chromeos builds. Original issue's description: > mus: Use TooltipManagerAura in NativeWidgetMus. > > mash now shows tooltips on hover over items. > > BUG=599558 > > Committed: https://crrev.com/1b3d5f1878974c14c21a29a13a93ef630c74d1f6 > Cr-Commit-Position: refs/heads/master@{#422562} TBR=sky@chromium.org,jonross@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599558 Committed: https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b Cr-Commit-Position: refs/heads/master@{#422599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -82 lines) Patch
M ui/views/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/corewm/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 11 chunks +36 lines, -43 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 6 chunks +3 lines, -27 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
Created Revert of mus: Use TooltipManagerAura in NativeWidgetMus.
4 years, 2 months ago (2016-10-03 23:35:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384083005/1
4 years, 2 months ago (2016-10-03 23:36:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:38:29 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:40:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b
Cr-Commit-Position: refs/heads/master@{#422599}

Powered by Google App Engine
This is Rietveld 408576698