Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: remoting/signaling/xmpp_signal_strategy.h

Issue 2384063008: Enables delegating signal strategy for It2Me Host. (Closed)
Patch Set: Fix unit tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/signaling/xmpp_signal_strategy.h
diff --git a/remoting/signaling/xmpp_signal_strategy.h b/remoting/signaling/xmpp_signal_strategy.h
index bd06015aa80e7c9190ac7ab2bae9c832bcbdc4ff..c6252be89ed34698ea6bf6f396e404ecee62f686 100644
--- a/remoting/signaling/xmpp_signal_strategy.h
+++ b/remoting/signaling/xmpp_signal_strategy.h
@@ -21,6 +21,8 @@ class URLRequestContextGetter;
namespace remoting {
// XmppSignalStrategy implements SignalStrategy using direct XMPP connection.
+// This class can be created on a different thread from the one it is used (when
+// Connect() is called).
class XmppSignalStrategy : public SignalStrategy {
public:
// XMPP Server configuration for XmppSignalStrategy.
@@ -61,6 +63,8 @@ class XmppSignalStrategy : public SignalStrategy {
const std::string& auth_token);
private:
+ // This ensures that even if a Listener deletes the current instance during
+ // OnSignalStrategyIncomingStanza(), we can delete |core_| asynchronously.
class Core;
std::unique_ptr<Core> core_;

Powered by Google App Engine
This is Rietveld 408576698