Enables delegating signal strategy for It2Me Host.

remoting/signaling/xmpp_signal_strategy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/signaling/xmpp_signal_strategy.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 146 matching lines @@
       xmpp_server_config_(xmpp_server_config),
       keep_alive_timer_(
           FROM_HERE,
           base::TimeDelta::FromSeconds(kKeepAliveIntervalSeconds),
           base::Bind(&Core::SendKeepAlive, base::Unretained(this)),
           true) {
 #if defined(NDEBUG)
   // Non-secure connections are allowed only for debugging.
   CHECK(xmpp_server_config_.use_tls);
 #endif
+  thread_checker_.DetachFromThread();

[Sergey Ulanov, 2016/10/05 21:49:07]

I don't think it's safe to detach from the thread here. Particularly
keep_alive_timer_ is initialized above and it gets attached to the current
thread, so SendKeepAlive() is called on the wrong thread. I would expect
DCHECK() in SendKeepAlive() fail as it would be called on the wrong thread.
Should be easy to fix by moving timer initialization to Connect().

[Sergey Ulanov, 2016/10/05 21:49:07]

Please add a comment xmpp_signal_strategy.h to make it clear that the class can
be created on a thread different from the one on which it's used.

[kelvinp, 2016/10/06 00:43:06]

Done.

[kelvinp, 2016/10/06 00:43:06]

Done.

 }
 
 XmppSignalStrategy::Core::~Core() {
   Disconnect();
 }
 
 void XmppSignalStrategy::Core::Connect() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   // Disconnect first if we are currently connected.
@@ skipping 373 matching lines @@
 std::string XmppSignalStrategy::GetNextId() {
   return base::Uint64ToString(base::RandUint64());
 }
 
 void XmppSignalStrategy::SetAuthInfo(const std::string& username,
                                      const std::string& auth_token) {
   core_->SetAuthInfo(username, auth_token);
 }
 
 }  // namespace remoting