Fix scrollbar overflow with ScaleToEnclosingRectSafe

Fix scrollbar overflow with ScaleToEnclosingRectSafe

ScaleToEnclosingRect DCHECKS that the scale that's being done won't
overflow, however this can't be known because the scrollbar's
internal scale is determined by page content.  Clamp these values
safely instead of DCHECKing.

R=danakj@chromium.org
BUG=652604
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/aa23d5d071524015ed425c4d6e981c1621479620
Cr-Commit-Position: refs/heads/master@{#422987}

[enne (OOO), 2016-10-04 20:45:14]

Description was changed from

==========
Fix scrollbar overflow with ScaleToEnclosingRectSafe

ScaleToEnclosingRect DCHECKS that the scale that's being done won't
overflow, however this can't be known because the scrollbar's
internal scale is determined by page content.  Clamp these values
safely instead of DCHECKing.

R=danakj@chromium.org
BUG=652604
==========

to

==========
Fix scrollbar overflow with ScaleToEnclosingRectSafe

ScaleToEnclosingRect DCHECKS that the scale that's being done won't
overflow, however this can't be known because the scrollbar's
internal scale is determined by page content.  Clamp these values
safely instead of DCHECKing.

R=danakj@chromium.org
BUG=652604
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-04 21:32:51]

LGTM

https://codereview.chromium.org/2384063007/diff/20001/ui/gfx/geometry/rect.h
File ui/gfx/geometry/rect.h (right):

https://codereview.chromium.org/2384063007/diff/20001/ui/gfx/geometry/rect.h#...
ui/gfx/geometry/rect.h:305: inline Rect ScaleToEnclosedRect(const Rect& rect,
Leave a comment here to use ScaleToEnclosingRectSafe() if the inputs are not
known to result in valid integer outputs?

[enne (OOO), 2016-10-04 21:42:57]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-10-04 21:42:57]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2384063007/#ps40001
(title: "With comment")

[commit-bot: I haz the power, 2016-10-04 21:43:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 23:12:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 23:14:45]

Description was changed from

==========
Fix scrollbar overflow with ScaleToEnclosingRectSafe

ScaleToEnclosingRect DCHECKS that the scale that's being done won't
overflow, however this can't be known because the scrollbar's
internal scale is determined by page content.  Clamp these values
safely instead of DCHECKing.

R=danakj@chromium.org
BUG=652604
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fix scrollbar overflow with ScaleToEnclosingRectSafe

ScaleToEnclosingRect DCHECKS that the scale that's being done won't
overflow, however this can't be known because the scrollbar's
internal scale is determined by page content.  Clamp these values
safely instead of DCHECKing.

R=danakj@chromium.org
BUG=652604
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/aa23d5d071524015ed425c4d6e981c1621479620
Cr-Commit-Position: refs/heads/master@{#422987}
==========

[commit-bot: I haz the power, 2016-10-04 23:14:46]

Patchset 3 (id:??) landed as
https://crrev.com/aa23d5d071524015ed425c4d6e981c1621479620
Cr-Commit-Position: refs/heads/master@{#422987}