Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2384063003: modify getWebViewClient behavior (Closed)

Created:
4 years, 2 months ago by Nate Fischer
Modified:
4 years, 2 months ago
Reviewers:
Tobias Sargeant
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

modify getWebViewClient behavior getWebViewClient returns the default client instead of null when the client is not yet set. BUG=627248 Implement getWebViewClient and getWebChromeClient Implement getWebViewClient and getWebChromeClient for new APIs in Android Committed: https://crrev.com/8e4aa5f84630cfa5934bec31f74a00dd0145f9d3 Cr-Commit-Position: refs/heads/master@{#422547}

Patch Set 1 #

Patch Set 2 : Fix base branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nate Fischer
This is the change as discussed on the android side (let me know if I'm ...
4 years, 2 months ago (2016-10-03 18:42:46 UTC) #2
Tobias Sargeant
On 2016/10/03 18:42:46, Nate Fischer wrote: > This is the change as discussed on the ...
4 years, 2 months ago (2016-10-03 20:53:00 UTC) #3
Nate Fischer
On 2016/10/03 at 20:53:00, tobiasjs wrote: > On 2016/10/03 18:42:46, Nate Fischer wrote: > > ...
4 years, 2 months ago (2016-10-03 21:13:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384063003/20001
4 years, 2 months ago (2016-10-03 21:14:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 21:49:56 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:52:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e4aa5f84630cfa5934bec31f74a00dd0145f9d3
Cr-Commit-Position: refs/heads/master@{#422547}

Powered by Google App Engine
This is Rietveld 408576698