Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384033002: reflow comments in web/tests (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, kinuko+watch, gavinp+prerender_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in web/tests BUG=563793 Committed: https://crrev.com/100fff395562319824e96af9328b847bb14043f2 Cr-Commit-Position: refs/heads/master@{#422343}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : comments (heh!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -335 lines) Patch
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 2 4 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 8 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TopControlsTest.cpp View 10 chunks +26 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 2 8 chunks +22 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 34 chunks +86 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 73 chunks +186 lines, -117 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 23 chunks +53 lines, -41 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Nico
4 years, 2 months ago (2016-10-02 01:42:26 UTC) #5
dcheng
LGTM with nits https://codereview.chromium.org/2384033002/diff/20001/third_party/WebKit/Source/web/tests/FrameTestHelpers.h File third_party/WebKit/Source/web/tests/FrameTestHelpers.h (right): https://codereview.chromium.org/2384033002/diff/20001/third_party/WebKit/Source/web/tests/FrameTestHelpers.h#newcode258 third_party/WebKit/Source/web/tests/FrameTestHelpers.h:258: // load remote frames. Tests that ...
4 years, 2 months ago (2016-10-02 01:50:56 UTC) #7
Nico
thanks! https://codereview.chromium.org/2384033002/diff/20001/third_party/WebKit/Source/web/tests/FrameTestHelpers.h File third_party/WebKit/Source/web/tests/FrameTestHelpers.h (right): https://codereview.chromium.org/2384033002/diff/20001/third_party/WebKit/Source/web/tests/FrameTestHelpers.h#newcode258 third_party/WebKit/Source/web/tests/FrameTestHelpers.h:258: // load remote frames. Tests that load On ...
4 years, 2 months ago (2016-10-02 01:56:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384033002/40001
4 years, 2 months ago (2016-10-02 01:57:06 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-02 03:35:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384033002/40001
4 years, 2 months ago (2016-10-02 03:38:20 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-02 03:57:09 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-02 03:59:45 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/100fff395562319824e96af9328b847bb14043f2
Cr-Commit-Position: refs/heads/master@{#422343}

Powered by Google App Engine
This is Rietveld 408576698