Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2383963002: [TTS] Log a warning when Contextual Cards backend fails. (Closed)

Created:
4 years, 2 months ago by Donn Denman
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Log a warning when Contextual Cards backend fails. When Contextual Search attempts to use the Contextual Cards backend, the response now gives backend-connection information so we can tell if the backend failed for some reason. If so, we log a warning on a debug build. BUG=647041 Committed: https://crrev.com/0d91f3915fb9a55f9ede3bc3e45328c85e32b160 Cr-Commit-Position: refs/heads/master@{#422485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Donn Denman
Theresa, PTAL.
4 years, 2 months ago (2016-10-03 17:00:12 UTC) #2
Theresa
lgtm
4 years, 2 months ago (2016-10-03 17:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383963002/1
4 years, 2 months ago (2016-10-03 17:28:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:16:50 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:20:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d91f3915fb9a55f9ede3bc3e45328c85e32b160
Cr-Commit-Position: refs/heads/master@{#422485}

Powered by Google App Engine
This is Rietveld 408576698