Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2383933002: Added message filter receiving frames from compositor

Created:
4 years, 2 months ago by ojars
Modified:
4 years, 2 months ago
Reviewers:
hush (inactive), boliu
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added message filter receiving frames from compositor BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -19 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M android_webview/browser/hardware_renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +25 lines, -5 lines 0 comments Download
M android_webview/browser/render_thread_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/render_thread_manager.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M content/browser/android/synchronous_compositor_observer.h View 3 chunks +20 lines, -2 lines 0 comments Download
M content/browser/android/synchronous_compositor_observer.cc View 2 chunks +48 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/android/synchronous_compositor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/render_process_host.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
ojars
4 years, 2 months ago (2016-10-01 02:18:27 UTC) #3 
This is just "something that works". Obviously code is of poor quality.

On of the things that, I think, should be considered is what happens if a frame,
for some reason, never comes. Then renderer needs to be unblocked otherwise.

Powered by Google App Engine
This is Rietveld 408576698