Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2383923002: Update threshold for RTCVideoEncoder SW fallback (Closed)

Created:
4 years, 2 months ago by emircan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Update threshold for RTCVideoEncoder SW fallback Earlier on, I added dynamic error tracking for the special issue explained on crbug.com/594161. We tried to reset HW decoder to handle H264 errors since SW fallback wasn't available. Since SW H264 is available now, this issue is no longer applicable. We should have less tolerance for error and fall back to SW. BUG=651489, webrtc:6377 TEST=Tested AppRTC loopback H264 decode on Mac. Review-Url: https://codereview.chromium.org/2375153003 Cr-Commit-Position: refs/heads/master@{#421847} (cherry picked from commit ed96795836993e079ff0de7cae4ef242894d4057) NOTRY=true NOPRESUBMIT=true TBR=wuchengli@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383923002/1
4 years, 2 months ago (2016-09-30 22:59:16 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 23:03:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698