Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2383903002: UX corrections to new FRE Welcome page. (Closed)

Created:
4 years, 2 months ago by tmartino
Modified:
4 years, 2 months ago
Reviewers:
michaelpg, Moe
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UX corrections to new FRE Welcome page. BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7c75f51bc2bde5dbc75467655268ad3b4eb4a4a9 Cr-Commit-Position: refs/heads/master@{#423234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -41 lines) Patch
M chrome/browser/resources/welcome/welcome.css View 8 chunks +61 lines, -36 lines 0 comments Download
M chrome/browser/resources/welcome/welcome.html View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tmartino
Hey Moe, A few CSS tweaks requested by the UXers on that Welcome Page you ...
4 years, 2 months ago (2016-09-30 21:09:58 UTC) #3
Moe
On 2016/09/30 21:09:58, tmartino wrote: > Hey Moe, > > A few CSS tweaks requested ...
4 years, 2 months ago (2016-10-04 15:11:02 UTC) #4
tmartino
Hey Michael, Here are some tweaks requested by the UXers for the Welcome Page you ...
4 years, 2 months ago (2016-10-04 15:17:12 UTC) #6
michaelpg
lgtm
4 years, 2 months ago (2016-10-04 21:52:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383903002/1
4 years, 2 months ago (2016-10-05 17:53:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 18:52:00 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:54:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c75f51bc2bde5dbc75467655268ad3b4eb4a4a9
Cr-Commit-Position: refs/heads/master@{#423234}

Powered by Google App Engine
This is Rietveld 408576698