Optimize startup time of notification code by removing unused code.

Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
Committed: https://crrev.com/5424cce0cb1592d7e5c025417861a1a540bd7569
Cr-Commit-Position: refs/heads/master@{#422550}

[Alexei Svitkine (slow), 2016-09-30 20:58:44]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:12:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-09-30 21:36:33]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 21:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-09-30 21:37:37]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent dev
release. Turns out, it's not even used - so this CL simply removes it.

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent dev
release. Turns out, it's not even used - so this CL simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

[Alexei Svitkine (slow), 2016-09-30 21:40:04]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-09-30 21:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:51:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-10-03 14:50:57]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 14:51:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 15:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 15:26:47]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-10-03 15:33:32]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent dev
release. Turns out, it's not even used - so this CL simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent Windows
dev release. Turns out, it's not even used - so this CL simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

[Alexei Svitkine (slow), 2016-10-03 15:33:44]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent Windows
dev release. Turns out, it's not even used - so this CL simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

[Alexei Svitkine (slow), 2016-10-03 15:33:58]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code it
was testing was removed because it wasn't referenced in any BUILD
file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

[Alexei Svitkine (slow), 2016-10-03 15:34:13]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2016-10-03 15:34:29]

asvitkine@chromium.org changed reviewers:
+ dimich@google.com

[Alexei Svitkine (slow), 2016-10-03 15:34:29]

dimich: PTAL

[Dmitry Titov, 2016-10-03 21:06:22]

dimich@chromium.org changed reviewers:
+ dimich@chromium.org

[Dmitry Titov, 2016-10-03 21:06:23]

LGTM, thanks for the good cleanup!

[Alexei Svitkine (slow), 2016-10-03 21:07:39]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:08:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:22:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexei Svitkine (slow), 2016-10-03 21:38:48]

asvitkine@chromium.org changed reviewers:
+ mukai@chromium.org
- dimich@google.com

[Alexei Svitkine (slow), 2016-10-03 21:38:48]

Oops, I thought Dmitry was an owner for ui/message_center too, but turns out he
only owns the chrome/ code.

+mukai - could you do an owners review? Thanks!

[Jun Mukai, 2016-10-03 21:45:35]

lgtm

[Alexei Svitkine (slow), 2016-10-03 21:45:48]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:55:02]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

[commit-bot: I haz the power, 2016-10-03 21:55:03]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-10-03 21:57:31]

Description was changed from

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848
==========

to

==========
Optimize startup time of notification code by removing unused code.

Generating the icon via GetAvatarIcon() can be expensive - according
to UMA sampling profiler it takes ~35ms mean time from a recent
Windows dev release. Turns out, it's not even used - so this CL
simply removes it.

Additionally, removes a unit test that stayed around after the code
it was testing was removed because it wasn't referenced in any
BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm

BUG=651848

Committed: https://crrev.com/5424cce0cb1592d7e5c025417861a1a540bd7569
Cr-Commit-Position: refs/heads/master@{#422550}
==========

[commit-bot: I haz the power, 2016-10-03 21:57:32]

Patchset 1 (id:??) landed as
https://crrev.com/5424cce0cb1592d7e5c025417861a1a540bd7569
Cr-Commit-Position: refs/heads/master@{#422550}