Move FrameMsg_NewFrame/NewFrameProxy to mojom

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 20 matching lines @@
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/input/synthetic_tap_gesture.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/child_process_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input/synthetic_tap_gesture_params.h"
 #include "content/common/input_messages.h"
+#include "content/common/renderer.mojom.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "content/test/content_browser_test_utils_internal.h"
 #include "content/test/test_frame_navigation_observer.h"
+#include "ipc/ipc.mojom.h"
 #include "ipc/ipc_security_test_util.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebInsecureRequestPolicy.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebSandboxFlags.h"
 #include "ui/display/display_switches.h"
 #include "ui/display/screen.h"
 #include "ui/events/event.h"
@@ skipping 3090 matching lines @@
   std::string result;
   EXPECT_TRUE(ExecuteScriptAndExtractString(
       tiptop_child,
       "window.domAutomationController.send(location.ancestorOrigins[0]);",
       &result));
   EXPECT_EQ(a_origin, result + "/");
 
   // Check that c.com frame's location.ancestorOrigins contains the correct
   // origin for its two ancestors. The topmost parent origin should be
   // replicated as part of mojom::Renderer::CreateView, and the middle frame
-  // (b.com's) origin should be replicated as part of FrameMsg_NewFrameProxy
-  // sent for b.com's frame in c.com's process.
+  // (b.com's) origin should be replicated as part of
+  // mojom::Renderer::CreateFrameProxy sent for b.com's frame in c.com's
+  // process.
   EXPECT_TRUE(ExecuteScriptAndExtractInt(
       middle_child,
       "window.domAutomationController.send(location.ancestorOrigins.length);",
       &ancestor_origins_length));
   EXPECT_EQ(2, ancestor_origins_length);
   EXPECT_TRUE(ExecuteScriptAndExtractString(
       middle_child,
       "window.domAutomationController.send(location.ancestorOrigins[0]);",
       &result));
   EXPECT_EQ(b_origin, result + "/");
@@ skipping 1447 matching lines @@
       root->child_at(1),
       "window.domAutomationController.send("
       "    parent.frames['frame1'].opener === parent);",
       &success));
   EXPECT_TRUE(success);
 }
 
 // Check that if a subframe has an opener, that opener is preserved when a new
 // RenderFrameProxy is created for that subframe in another renderer process.
 // Similar to NavigateSubframeWithOpener, but this test verifies the subframe
-// opener plumbing for FrameMsg_NewFrameProxy, whereas
-// NavigateSubframeWithOpener targets FrameMsg_NewFrame.
+// opener plumbing for mojom::Renderer::CreateFrameProxy(), whereas
+// NavigateSubframeWithOpener targets mojom::Renderer::CreateFrame().
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
                        NewRenderFrameProxyPreservesOpener) {
   GURL main_url(
       embedded_test_server()->GetURL("foo.com", "/post_message.html"));
   EXPECT_TRUE(NavigateToURL(shell(), main_url));
 
   FrameTreeNode* root = web_contents()->GetFrameTree()->root();
 
   // Open a popup with a cross-site page that has two subframes.
   GURL popup_url(embedded_test_server()->GetURL(
@@ skipping 1418 matching lines @@
       root->child_at(0)->render_manager()->GetProxyToParent()->GetRoutingID();
 
   // Tell main frame A to delete its subframe B.
   FrameDeletedObserver observer(root->child_at(0));
   EXPECT_TRUE(ExecuteScript(
       root, "document.body.removeChild(document.querySelector('iframe'));"));
 
   // Send the message to create a proxy for B's new child frame in A.  This
   // used to crash, as parent_routing_id refers to a proxy that doesn't exist
   // anymore.
-  process_a->Send(new FrameMsg_NewFrameProxy(
-      new_routing_id, view_routing_id, MSG_ROUTING_NONE, parent_routing_id,
-      FrameReplicationState()));
+  static_cast<RenderProcessHostImpl*>(process_a)->GetRendererInterface()

[ncarter (slow), 2016/09/30 23:35:14]

Note that this cast is safe (the only place where we can reliably cast from RPH
to RPHI is in _browsertest.cc code).

+      ->CreateFrameProxy(new_routing_id, view_routing_id, MSG_ROUTING_NONE,
+                         parent_routing_id, FrameReplicationState());
 
   // Ensure the subframe is detached in the browser process.
   observer.Wait();
   EXPECT_EQ(0U, root->child_count());
 
   // Make sure process A did not crash.
   int child_count = 0;
   EXPECT_TRUE(ExecuteScriptAndExtractInt(
       root, "domAutomationController.send(frames.length)", &child_count));
   EXPECT_EQ(0, child_count);
@@ skipping 41 matching lines @@
           : node->render_manager()->pending_frame_host()->GetRoutingID();
   int proxy_routing_id =
       node->render_manager()->GetProxyToParent()->GetRoutingID();
 
   // Now go to c.com so the navigation to a.com is cancelled and send an IPC
   // to create a new RenderFrame with the routing id of the previously pending
   // one.
   NavigateFrameToURL(node,
                      embedded_test_server()->GetURL("c.com", "/title2.html"));
   {
-    FrameMsg_NewFrame_Params params;
-    params.routing_id = frame_routing_id;
-    params.proxy_routing_id = proxy_routing_id;
-    params.opener_routing_id = MSG_ROUTING_NONE;
-    params.parent_routing_id =
+    mojom::CreateFrameParamsPtr params = mojom::CreateFrameParams::New();
+    params->routing_id = frame_routing_id;
+    params->proxy_routing_id = proxy_routing_id;
+    params->opener_routing_id = IPC::mojom::kRoutingIdNone;
+    params->parent_routing_id =
         shell()->web_contents()->GetMainFrame()->GetRoutingID();
-    params.previous_sibling_routing_id = MSG_ROUTING_NONE;
-    params.widget_params.routing_id = MSG_ROUTING_NONE;
-    params.widget_params.hidden = true;
-    params.replication_state.name = "name";
-    params.replication_state.unique_name = "name";
-
-    process->Send(new FrameMsg_NewFrame(params));
+    params->previous_sibling_routing_id = IPC::mojom::kRoutingIdNone;
+    params->widget_params = mojom::CreateFrameWidgetParams::New();
+    params->widget_params->routing_id = IPC::mojom::kRoutingIdNone;
+    params->widget_params->hidden = true;
+    params->replication_state.name = "name";
+    params->replication_state.unique_name = "name";
+    static_cast<RenderProcessHostImpl*>(process)->GetRendererInterface()
+        ->CreateFrame(std::move(params));
   }
 
   // The test must wait for the process to exit, but if there is no leak, the
   // RenderFrame will be properly created and there will be no crash.
   // Therefore, navigate the main frame to completely different site, which
   // will cause the original process to exit cleanly.
   EXPECT_TRUE(NavigateToURL(
       shell(), embedded_test_server()->GetURL("d.com", "/title3.html")));
   watcher.Wait();
   EXPECT_TRUE(watcher.did_exit_normally());
@@ skipping 33 matching lines @@
           node->current_frame_host()->GetSiteInstance());
 
   // Have the parent frame remove the child frame from its DOM. This should
   // result in the child RenderFrame being deleted in the remote process.
   EXPECT_TRUE(ExecuteScript(contents,
                             "document.body.removeChild("
                             "document.querySelectorAll('iframe')[0])"));
   EXPECT_EQ(1U, contents->GetFrameTree()->root()->child_count());
 
   {
-    FrameMsg_NewFrame_Params params;
-    params.routing_id = frame_routing_id;
-    params.proxy_routing_id = MSG_ROUTING_NONE;
-    params.opener_routing_id = MSG_ROUTING_NONE;
-    params.parent_routing_id = parent_routing_id;
-    params.previous_sibling_routing_id = MSG_ROUTING_NONE;
-    params.widget_params.routing_id = widget_routing_id;
-    params.widget_params.hidden = true;
-    params.replication_state.name = "name";
-    params.replication_state.unique_name = "name";
+    mojom::CreateFrameParamsPtr params = mojom::CreateFrameParams::New();
+    params->routing_id = frame_routing_id;
+    params->proxy_routing_id = IPC::mojom::kRoutingIdNone;
+    params->opener_routing_id = IPC::mojom::kRoutingIdNone;
+    params->parent_routing_id = parent_routing_id;
+    params->previous_sibling_routing_id = IPC::mojom::kRoutingIdNone;
+    params->widget_params = mojom::CreateFrameWidgetParams::New();
+    params->widget_params->routing_id = widget_routing_id;
+    params->widget_params->hidden = true;
+    params->replication_state.name = "name";
+    params->replication_state.unique_name = "name";
 
-    process->Send(new FrameMsg_NewFrame(params));
+    static_cast<RenderProcessHostImpl*>(process)->GetRendererInterface()
+        ->CreateFrame(std::move(params));
   }
 
   // The test must wait for the process to exit, but if there is no leak, the
   // RenderFrame will be properly created and there will be no crash.
   // Therefore, navigate the remaining subframe to completely different site,
   // which will cause the original process to exit cleanly.
   NavigateFrameToURL(contents->GetFrameTree()->root()->child_at(0),
                      embedded_test_server()->GetURL("d.com", "/title3.html"));
   watcher.Wait();
   EXPECT_TRUE(watcher.did_exit_normally());
@@ skipping 1997 matching lines @@
       " Site A ------------ proxies for B C\n"
       "   +--Site B ------- proxies for A C\n"
       "        +--Site C -- proxies for A B\n"
       "Where A = http://a.com/\n"
       "      B = http://b.com/\n"
       "      C = http://c.com/",
       DepictFrameTree(root));
 }
 
 }  // namespace content