Move FrameMsg_NewFrame/NewFrameProxy to mojom

content/browser/frame_host/render_frame_proxy_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_proxy_host.h"
 
 #include <utility>
 
 #include "base/lazy_instance.h"
 #include "content/browser/bad_message.h"
@@ skipping 166 matching lines @@
     parent_routing_id = parent_proxy->GetRoutingID();
     CHECK_NE(parent_routing_id, MSG_ROUTING_NONE);
   }
 
   int opener_routing_id = MSG_ROUTING_NONE;
   if (frame_tree_node_->opener()) {
     opener_routing_id = frame_tree_node_->render_manager()->GetOpenerRoutingID(
         site_instance_.get());
   }
 
-  Send(new FrameMsg_NewFrameProxy(routing_id_,
-                                  frame_tree_node_->frame_tree()
-                                      ->GetRenderViewHost(site_instance_.get())
-                                      ->GetRoutingID(),
-                                  opener_routing_id,
-                                  parent_routing_id,
-                                  frame_tree_node_
-                                      ->current_replication_state()));
+  int view_routing_id = frame_tree_node_->frame_tree()
+      ->GetRenderViewHost(site_instance_.get())->GetRoutingID();
+  static_cast<RenderProcessHostImpl*>(GetProcess())->GetRendererInterface()

[ncarter (slow), 2016/09/30 23:35:14]

RPH->RPHI is not a safe cast; very similar to the RenderThread/MockRenderThread
situation, MockRenderProcessHost is not a RenderProcessHostImpl. So, code that
does this kind of cast will crash -- or worse -- if executed from inside a
content_unittest. If this works today, it's just because we don't have
content_unittest coverage for this case.

Which is possibly not too surprising if it is the case for RenderFrameProxyHost,
which is pretty hard to exercise outside of a browsertest, but I suspect we are
going to need a solution to this pattern in general that avoids the bad  cast.

+      ->CreateFrameProxy(routing_id_, view_routing_id, opener_routing_id,
+                         parent_routing_id,
+                         frame_tree_node_->current_replication_state());
 
   render_frame_proxy_created_ = true;
 
   // For subframes, initialize the proxy's FrameOwnerProperties only if they
   // differ from default values.
   bool should_send_properties =
       frame_tree_node_->frame_owner_properties() != FrameOwnerProperties();
   if (frame_tree_node_->parent() && should_send_properties) {
     Send(new FrameMsg_SetFrameOwnerProperties(
         routing_id_, frame_tree_node_->frame_owner_properties()));
@@ skipping 164 matching lines @@
   target_rfh->Send(new FrameMsg_AdvanceFocus(target_rfh->GetRoutingID(), type,
                                              source_proxy_routing_id));
 }
 
 void RenderFrameProxyHost::OnFrameFocused() {
   frame_tree_node_->current_frame_host()->delegate()->SetFocusedFrame(
       frame_tree_node_, GetSiteInstance());
 }
 
 }  // namespace content