Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2383843002: Fix build of pdf_hint_table_fuzzer. (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix build of pdf_hint_table_fuzzer. Restore CPDF_Dictionary default constructor. Use it in places where reasonable in the code. TBR=dsinclair@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cd5bca472261cebc60b37d7bbc8b81b4091a6cd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -30 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_dictionary.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 8 chunks +9 lines, -13 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_filespec_unittest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield_unittest.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M core/fxge/dib/fx_dib_engine_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383843002/1
4 years, 2 months ago (2016-09-30 17:31:09 UTC) #5
dsinclair
lgtm
4 years, 2 months ago (2016-09-30 17:32:56 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:45:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cd5bca472261cebc60b37d7bbc8b81b4091a...

Powered by Google App Engine
This is Rietveld 408576698