Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238383004: Clean-up coding style (Closed)

Created:
6 years, 8 months ago by jeado ko
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/csp_validator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/event_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/event_filter_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/extension_builder.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/common/message_bundle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jeado ko
Please review this.
6 years, 8 months ago (2014-04-15 01:37:05 UTC) #1
Yoyo Zhou
LGTM
6 years, 8 months ago (2014-04-15 01:49:48 UTC) #2
jeado ko
The CQ bit was checked by haibane84@gmail.com
6 years, 8 months ago (2014-04-15 01:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibane84@gmail.com/238383004/1
6 years, 8 months ago (2014-04-15 01:55:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 02:41:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61417
6 years, 8 months ago (2014-04-15 02:41:45 UTC) #6
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 8 months ago (2014-04-15 04:08:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibane84@gmail.com/238383004/1
6 years, 8 months ago (2014-04-15 04:09:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 11:09:09 UTC) #9
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-15 11:09:10 UTC) #10
jeado ko
The CQ bit was checked by haibane84@gmail.com
6 years, 8 months ago (2014-04-15 23:54:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibane84@gmail.com/238383004/1
6 years, 8 months ago (2014-04-15 23:55:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haibane84@gmail.com/238383004/1
6 years, 8 months ago (2014-04-16 01:34:13 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 07:13:14 UTC) #14
Message was sent while issue was closed. 
Change committed as 264144

Powered by Google App Engine
This is Rietveld 408576698