Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 238383003: Revert of Base: Make FileProxy automaticaly close the file on a worker thread. (Closed)

Created:
6 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Revert of Base: Make FileProxy automaticaly close the file on a worker thread. (https://codereview.chromium.org/231703002/) Reason for revert: Triggering AssertIOAllowed on a handful of Blink LayoutTests. Original issue's description: > Base: Make FileProxy automaticaly close the file on a worker thread. > > This CL removes the restriction that callers should call Close before > deleting the object if they want to make sure the file is not closed > on the current thread. > > BUG=322664 > TEST=base_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263675 TBR=willchan@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -37 lines) Patch
M base/files/file.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file_proxy.h View 2 chunks +5 lines, -3 lines 0 comments Download
M base/files/file_proxy.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M base/files/file_proxy_unittest.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
Created Revert of Base: Make FileProxy automaticaly close the file on a worker thread.
6 years, 8 months ago (2014-04-15 00:42:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/238383003/1
6 years, 8 months ago (2014-04-15 00:43:27 UTC) #2
commit-bot: I haz the power
Change committed as 263758
6 years, 8 months ago (2014-04-15 00:47:55 UTC) #3
rvargas (doing something else)
On 2014/04/15 00:47:55, I haz the power (commit-bot) wrote: > Change committed as 263758 Do ...
6 years, 8 months ago (2014-04-15 15:20:17 UTC) #4
leviw_travelin_and_unemployed
6 years, 8 months ago (2014-04-15 16:01:57 UTC) #5
Message was sent while issue was closed.
See some crashes in the results here:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Powered by Google App Engine
This is Rietveld 408576698