With force signin enabled, the signin dialog will be displayed after profile creation instead of br…

With force signin enabled, the signin dialog will be displayed after profile creation instead of browser window.

BUG=642059
Committed: https://crrev.com/9cff516ab6af88aa64456a829783de31c9d3fadb
Cr-Commit-Position: refs/heads/master@{#422173}

[zmin, 2016-09-30 17:08:19]

zmin@chromium.org changed reviewers:
+ anthonyvd@chromium.org, chrome-enterprise-changes@google.com,
rogerta@chromium.org

[zmin, 2016-09-30 17:08:20]

Hi Roger, Anthony,

Can you please review this CL?

Owen

[anthonyvd, 2016-09-30 17:30:15]

lgtm w/ a couple nits

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/signin_create_profile_handler.cc (right):

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/signin_create_profile_handler.cc:426: //
TODO(zmin): Remove the swither once the UserManager API is finished on Mac.
nit: typo in "swither"

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/signin_utils.cc (right):

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/signin_utils.cc:83: DCHECK(prefs);
This DCHECK seems superfluous since prefs is dereferenced on the next line.
Since not having a local_state here is probably an unrecoverable edge case (and
Chrome probably crashed before getting here) I'd probably just remove the DCHECK
altogether.

[zmin, 2016-09-30 17:41:21]

Description was changed from

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059
==========

to

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059
==========

[zmin, 2016-09-30 17:41:21]

zmin@chromium.org changed reviewers:
- chrome-enterprise-changes@google.com

[zmin, 2016-09-30 17:41:48]

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/signin_create_profile_handler.cc (right):

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/signin_create_profile_handler.cc:426: //
TODO(zmin): Remove the swither once the UserManager API is finished on Mac.
On 2016/09/30 17:30:15, anthonyvd wrote:
> nit: typo in "swither"

Done.

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/signin_utils.cc (right):

https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/signin_utils.cc:83: DCHECK(prefs);
On 2016/09/30 17:30:15, anthonyvd wrote:
> This DCHECK seems superfluous since prefs is dereferenced on the next line.
> Since not having a local_state here is probably an unrecoverable edge case
(and
> Chrome probably crashed before getting here) I'd probably just remove the
DCHECK
> altogether.

Done.

[Roger Tawa OOO till Jul 10th, 2016-09-30 18:15:46]

lgtm

[zmin, 2016-09-30 18:17:25]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:04:40]

Dry run: This issue passed the CQ dry run.

[zmin, 2016-09-30 19:06:26]

The CQ bit was checked by zmin@chromium.org

[zmin, 2016-09-30 19:06:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2383823002/#ps20001
(title: "cr")

[commit-bot: I haz the power, 2016-09-30 19:07:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:15:12]

Description was changed from

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059
==========

to

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059
==========

[commit-bot: I haz the power, 2016-09-30 19:15:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 19:18:57]

Description was changed from

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059
==========

to

==========
With force signin enabled, the signin dialog will be displayed after profile
creation instead of browser window.

BUG=642059

Committed: https://crrev.com/9cff516ab6af88aa64456a829783de31c9d3fadb
Cr-Commit-Position: refs/heads/master@{#422173}
==========

[commit-bot: I haz the power, 2016-09-30 19:18:58]

Patchset 2 (id:??) landed as
https://crrev.com/9cff516ab6af88aa64456a829783de31c9d3fadb
Cr-Commit-Position: refs/heads/master@{#422173}