Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2383823002: With force signin enabled, the signin dialog will be displayed after profile creation instead of br… (Closed)

Created:
4 years, 2 months ago by zmin
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chrome-enterprise-changes_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With force signin enabled, the signin dialog will be displayed after profile creation instead of browser window. BUG=642059 Committed: https://crrev.com/9cff516ab6af88aa64456a829783de31c9d3fadb Cr-Commit-Position: refs/heads/master@{#422173}

Patch Set 1 #

Total comments: 4

Patch Set 2 : cr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/signin_create_profile_handler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc View 4 chunks +59 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_utils.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
zmin
Hi Roger, Anthony, Can you please review this CL? Owen
4 years, 2 months ago (2016-09-30 17:08:20 UTC) #2
anthonyvd
lgtm w/ a couple nits https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc File chrome/browser/ui/webui/signin/signin_create_profile_handler.cc (right): https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc#newcode426 chrome/browser/ui/webui/signin/signin_create_profile_handler.cc:426: // TODO(zmin): Remove the ...
4 years, 2 months ago (2016-09-30 17:30:15 UTC) #3
zmin
https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc File chrome/browser/ui/webui/signin/signin_create_profile_handler.cc (right): https://codereview.chromium.org/2383823002/diff/1/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc#newcode426 chrome/browser/ui/webui/signin/signin_create_profile_handler.cc:426: // TODO(zmin): Remove the swither once the UserManager API ...
4 years, 2 months ago (2016-09-30 17:41:48 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
4 years, 2 months ago (2016-09-30 18:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383823002/20001
4 years, 2 months ago (2016-09-30 19:07:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 19:15:13 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 19:18:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cff516ab6af88aa64456a829783de31c9d3fadb
Cr-Commit-Position: refs/heads/master@{#422173}

Powered by Google App Engine
This is Rietveld 408576698