tools/metrics/histograms/histograms.xml - Issue 23838003: Add HTTP Peer to DownloadSources enumeration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 23838003: Add HTTP Peer to DownloadSources enumeration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 199895b37352293f40a0ec3a920ce28c60f79d62..610869d51c64eee9cf67118c7197fa350ae1e532 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -25137,7 +25137,11 @@ other types of suffix sets.

- <int value="3" label="Both HTTP and HTTPS Server"/>

+ <int value="3" label="HTTP Server, HTTPS Server"/>

Ilya Sherman 2013/09/03 22:43:23 nit: IMO "and" would be clearer than a comma, here

+ <int value="4" label="HTTP Peer Only"/>

+ <int value="5" label="HTTP Peer, HTTPS Server"/>

+ <int value="6" label="HTTP Peer, HTTP Server"/>

+ <int value="7" label="HTTP Peer, HTTPS Server, HTTP Server"/>

</enum>

@@ -25911,6 +25915,7 @@ other types of suffix sets.

</fieldtrial>

+ <group name="HttpPeer" label="Download Source: HTTP Peer"/>

<affected-histogram name="Installer.SuccessfulMBsDownloadedFrom"/>

« no previous file with comments | « no previous file | no next file » | no next file with comments »