Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2383773002: Prevent RFH from attempting to transfer after it's been swapped out (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 53c566373592ee72bfa79b6a6cd4782fb7479580..d4773a5d091d9c4e8860b4f95b71668400baf2c7 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -645,6 +645,10 @@ bool NavigationHandleImpl::MaybeTransferAndProceedInternal() {
if (IsBrowserSideNavigationEnabled())
return true;
+ // A navigation from a RenderFrame that is no longer active should not attempt
+ // to transfer.
+ CHECK(render_frame_host_->is_active());
+
// Subframes shouldn't swap processes unless out-of-process iframes are
// possible.
if (!IsInMainFrame() && !SiteIsolationPolicy::AreCrossProcessFramesPossible())

Powered by Google App Engine
This is Rietveld 408576698