Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2383773002: Prevent RFH from attempting to transfer after it's been swapped out (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 53c566373592ee72bfa79b6a6cd4782fb7479580..7904e69d4a37051d293b2071bb780b76a14ae894 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -645,6 +645,10 @@ bool NavigationHandleImpl::MaybeTransferAndProceedInternal() {
if (IsBrowserSideNavigationEnabled())
return true;
+ // A navigation form a renderer that is no longer active should not attempt to
nasko 2016/10/04 16:07:39 minor nit: s/renderer/RenderFrame/
clamy 2016/10/04 16:12:53 Done.
+ // transfer.
+ CHECK(render_frame_host_->is_active());
+
// Subframes shouldn't swap processes unless out-of-process iframes are
// possible.
if (!IsInMainFrame() && !SiteIsolationPolicy::AreCrossProcessFramesPossible())

Powered by Google App Engine
This is Rietveld 408576698