Prevent RFH from attempting to transfer after it's been swapped out

content/public/test/browser_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 #define CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 
 #include <queue>
 #include <string>
 #include <vector>
@@ skipping 596 matching lines @@
  public:
   // Monitors any frame in WebContents.
   TestNavigationManager(WebContents* web_contents, const GURL& url);
 
   ~TestNavigationManager() override;
 
   // Waits until the navigation request is ready to be sent to the network
   // stack. Returns false if the request was aborted before starting.
   WARN_UNUSED_RESULT bool WaitForWillStartRequest();
 
+  // Waits until the navigation response has been sent received. Returns false
+  // if the request was aborted before getting a response.
+  WARN_UNUSED_RESULT bool WaitForWillProcessResponse();

[nasko, 2016/09/30 23:21:33]

nit: I think it will be a bit more readable as WaitForResponse. While the
lengthy name is fully explanatory of what exact event will cause it, I think the
WillProcess part doesn't add as much to be needed.

If you go that route, we can rename the above method too in a separate CL.

[clamy, 2016/10/04 11:54:41]

Acknowledged. Since more of the code needs to be refactored, I'll do a followup
CL to improve the TestNavigationManager.

+
   // Waits until the navigation has been finished. Will automatically resume
   // navigations paused before this point.
   void WaitForNavigationFinished();
 
  protected:
   // Derived classes can override if they want to filter out navigations. This
   // is called from DidStartNavigation.
   virtual bool ShouldMonitorNavigation(NavigationHandle* handle);
 
  private:
   // WebContentsObserver:
   void DidStartNavigation(NavigationHandle* handle) override;
   void DidFinishNavigation(NavigationHandle* handle) override;
 
   // Called when the NavigationThrottle pauses the navigation in
   // WillStartRequest.
   void OnWillStartRequest();
 
+  // Called when the NavigationThrottle pauses the navigation in
+  // WillProcessResponse.
+  void OnWillProcessResponse();
+
   // Resumes the navigation.
   void ResumeNavigation();
 
   const GURL url_;
-  bool navigation_paused_;
+  bool navigation_paused_in_will_start_;
+  bool navigation_paused_in_will_process_response_;
   NavigationHandle* handle_;
   bool handled_navigation_;
   scoped_refptr<MessageLoopRunner> will_start_loop_runner_;
+  scoped_refptr<MessageLoopRunner> will_process_response_loop_runner_;

[nasko, 2016/09/30 23:21:33]

Why do we need separate MessageLoopRunner?

[clamy, 2016/10/04 11:54:41]

I added another one since it meant the least amount of modifications to the
existing code, and wanted to land this ASAP. The code can probably be
refactored, but to use only one MessageLoopRunner we'd need to keep track of the
current & desired states. I'd rather do this in another patch.

   scoped_refptr<MessageLoopRunner> did_finish_loop_runner_;
 
   base::WeakPtrFactory<TestNavigationManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TestNavigationManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_