Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4507)

Unified Diff: content/browser/devtools/protocol/target_handler.h

Issue 2383743003: [DevTools] Auto-attach to cross-process subframes under experiment. (Closed)
Patch Set: some ui Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/target_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/target_handler.h
diff --git a/content/browser/devtools/protocol/target_handler.h b/content/browser/devtools/protocol/target_handler.h
index f3ddac30d99b5450c004019a02fc9ed910b1d45f..223a085b2283947315da323c6d59d0508130c508 100644
--- a/content/browser/devtools/protocol/target_handler.h
+++ b/content/browser/devtools/protocol/target_handler.h
@@ -32,11 +32,13 @@ class TargetHandler : public DevToolsAgentHostClient,
void Detached();
void UpdateServiceWorkers();
+ void UpdateFrames();
// Domain implementation.
Response Enable();
Response Disable();
Response SetWaitForDebuggerOnStart(bool value);
+ Response SetAttachToFrames(bool value);
Response SendMessageToTarget(const std::string& target_id,
const std::string& message);
Response GetTargetInfo(const std::string& target_id,
@@ -44,7 +46,12 @@ class TargetHandler : public DevToolsAgentHostClient,
Response ActivateTarget(const std::string& target_id);
private:
+ using HostsMap = std::map<std::string, scoped_refptr<DevToolsAgentHost>>;
+
void UpdateServiceWorkers(bool waiting_for_debugger);
+ void ReattachTargetsOfType(const HostsMap& new_hosts,
+ const std::string& type,
+ bool waiting_for_debugger);
void AttachToTargetInternal(DevToolsAgentHost* host,
bool waiting_for_debugger);
void DetachFromTargetInternal(DevToolsAgentHost* host);
@@ -65,8 +72,9 @@ class TargetHandler : public DevToolsAgentHostClient,
std::unique_ptr<Client> client_;
bool enabled_;
bool wait_for_debugger_on_start_;
+ bool attach_to_frames_;
RenderFrameHostImpl* render_frame_host_;
- std::map<std::string, scoped_refptr<DevToolsAgentHost>> attached_hosts_;
+ HostsMap attached_hosts_;
std::set<GURL> frame_urls_;
DISALLOW_COPY_AND_ASSIGN(TargetHandler);
« no previous file with comments | « no previous file | content/browser/devtools/protocol/target_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698