Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2383743002: [build] Use same symbol level as chromium for android (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Torne
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Use same symbol level as chromium for android This makes our configuration similar to Chromium's for android performance testing. This blocks deps'ing in: https://codereview.chromium.org/2377013002 BUG=chromium:648948 NOTRY=true Committed: https://crrev.com/679409e800a173ef7830ba8781dfa83506c59ccf Cr-Commit-Position: refs/heads/master@{#39915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M infra/mb/mb_config.pyl View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Achenbach
PTAL
4 years, 2 months ago (2016-09-30 11:19:59 UTC) #3
vogelheim
I don't get it... CL description says, "Use same symbol level as chromium for android", ...
4 years, 2 months ago (2016-09-30 11:27:59 UTC) #4
Michael Achenbach
On 2016/09/30 11:27:59, vogelheim wrote: > I don't get it... > > CL description says, ...
4 years, 2 months ago (2016-09-30 11:43:52 UTC) #5
vogelheim
lgtm
4 years, 2 months ago (2016-09-30 11:46:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383743002/1
4 years, 2 months ago (2016-09-30 11:56:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:59:02 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:59:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/679409e800a173ef7830ba8781dfa83506c59ccf
Cr-Commit-Position: refs/heads/master@{#39915}

Powered by Google App Engine
This is Rietveld 408576698