Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2383733002: Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2381233003/ ) Reason for revert: Causing a lot of editing layout tests to fail by hitting the DCHECK in createVisibleSelection. Original issue's description: > Prune CreateVisibleSelectionDeprecated from SpellChecker > > BUG=651373 > > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1 > Cr-Commit-Position: refs/heads/master@{#422055} TBR=yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651373 Committed: https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7 Cr-Commit-Position: refs/heads/master@{#422079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xiaocheng
Created Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker
4 years, 2 months ago (2016-09-30 10:58:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383733002/1
4 years, 2 months ago (2016-09-30 10:58:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 10:59:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7 Cr-Commit-Position: refs/heads/master@{#422079}
4 years, 2 months ago (2016-09-30 11:01:53 UTC) #6
Xiaocheng
4 years, 2 months ago (2016-10-03 04:27:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2390573002/ by xiaochengh@chromium.org.

The reason for reverting is: The DCHECK is removed, so this patch can be
relanded..

Powered by Google App Engine
This is Rietveld 408576698