Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: media/mojo/services/demuxer_stream_provider_shim.cc

Issue 2383663002: Make mojo renderer capable of supporting multiple streams/tracks (Closed)
Patch Set: CR feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/mojo/services/demuxer_stream_provider_shim.h" 5 #include "media/mojo/services/demuxer_stream_provider_shim.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/callback_helpers.h" 11 #include "base/callback_helpers.h"
12 12
13 namespace media { 13 namespace media {
14 14
15 DemuxerStreamProviderShim::DemuxerStreamProviderShim( 15 DemuxerStreamProviderShim::DemuxerStreamProviderShim(
16 mojom::DemuxerStreamPtr audio, 16 std::vector<mojom::DemuxerStreamPtr> streams,
17 mojom::DemuxerStreamPtr video,
18 const base::Closure& demuxer_ready_cb) 17 const base::Closure& demuxer_ready_cb)
19 : demuxer_ready_cb_(demuxer_ready_cb), 18 : demuxer_ready_cb_(demuxer_ready_cb),
20 streams_ready_(0), 19 streams_ready_(0),
21 weak_factory_(this) { 20 weak_factory_(this) {
22 DCHECK(audio || video); 21 DCHECK(!streams.empty());
23 DCHECK(!demuxer_ready_cb_.is_null()); 22 DCHECK(!demuxer_ready_cb_.is_null());
24 23
25 if (audio) { 24 for (auto& s : streams) {
26 streams_.push_back(new MojoDemuxerStreamAdapter( 25 streams_.emplace_back(new MojoDemuxerStreamAdapter(
27 std::move(audio), base::Bind(&DemuxerStreamProviderShim::OnStreamReady, 26 std::move(s), base::Bind(&DemuxerStreamProviderShim::OnStreamReady,
28 weak_factory_.GetWeakPtr()))); 27 weak_factory_.GetWeakPtr())));
29 }
30
31 if (video) {
32 streams_.push_back(new MojoDemuxerStreamAdapter(
33 std::move(video), base::Bind(&DemuxerStreamProviderShim::OnStreamReady,
34 weak_factory_.GetWeakPtr())));
35 } 28 }
36 } 29 }
37 30
38 DemuxerStreamProviderShim::~DemuxerStreamProviderShim() { 31 DemuxerStreamProviderShim::~DemuxerStreamProviderShim() {
39 } 32 }
40 33
34 // This function returns only the first stream of the given |type| for now.
35 // TODO: Make this work with multiple streams.
xhwang 2017/01/31 07:49:07 nit: TODO(ldap)
servolk 2017/01/31 17:38:05 Done.
41 DemuxerStream* DemuxerStreamProviderShim::GetStream(DemuxerStream::Type type) { 36 DemuxerStream* DemuxerStreamProviderShim::GetStream(DemuxerStream::Type type) {
42 DCHECK(demuxer_ready_cb_.is_null()); 37 DCHECK(demuxer_ready_cb_.is_null());
43 for (auto* stream : streams_) { 38 for (auto& stream : streams_) {
44 if (stream->type() == type) 39 if (stream->type() == type)
45 return stream; 40 return stream.get();
46 } 41 }
47 42
48 return nullptr; 43 return nullptr;
49 } 44 }
50 45
51 void DemuxerStreamProviderShim::OnStreamReady() { 46 void DemuxerStreamProviderShim::OnStreamReady() {
52 if (++streams_ready_ == streams_.size()) 47 if (++streams_ready_ == streams_.size())
53 base::ResetAndReturn(&demuxer_ready_cb_).Run(); 48 base::ResetAndReturn(&demuxer_ready_cb_).Run();
54 } 49 }
55 50
56 } // namespace media 51 } // namespace media
OLDNEW
« no previous file with comments | « media/mojo/services/demuxer_stream_provider_shim.h ('k') | media/mojo/services/media_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698