Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2383633002: gpu: Add default constructor to SharedMemoryLimits. (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 2 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org, mkollaro, sl1pkn07_gmail.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add default constructor to SharedMemoryLimits. We get compiler errors due to missing a constructor. R=jbauman@chromium.org BUG=606343 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ac08df435d06f26f46ee25b1b962bbf71a160dc1 Cr-Commit-Position: refs/heads/master@{#421897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gpu/command_buffer/client/shared_memory_limits.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
danakj
4 years, 2 months ago (2016-09-29 19:12:28 UTC) #3
jbauman
lgtm
4 years, 2 months ago (2016-09-29 19:19:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383633002/1
4 years, 2 months ago (2016-09-29 19:20:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 19:26:43 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 19:29:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac08df435d06f26f46ee25b1b962bbf71a160dc1
Cr-Commit-Position: refs/heads/master@{#421897}

Powered by Google App Engine
This is Rietveld 408576698