Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2383623003: Revert of [wasm] Strongly typed compiled module (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Strongly typed compiled module (patchset #7 id:120001 of https://codereview.chromium.org/2340623003/ ) Reason for revert: Forgot to correctly clone a heap number. Reverting to fix. Original issue's description: > [wasm] Strongly typed compiled module > > First stab at strongly typing the wasm compiled module FixedArray. The goal > is to improve maintainability of the data structures living on the JS heap. > > My goal is to do so just for the first level, since we plan to eventually > avoid copying the metadata bits that are currently copied from the decoded > structures (export/import metadata, etc). > > Subsequent CLs will try and consolidate internal functions working off the > compiled module as members, and evaluate what the actual interface with the > rest of the world of this type should be - we may be able to completely > move it in the cc file, for instance. > > BUG= > > Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 > Cr-Commit-Position: refs/heads/master@{#39890} TBR=bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/bf2b4018189e1f437ac4b43bfeeef444b71186f2 Cr-Commit-Position: refs/heads/master@{#39893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -250 lines) Patch
M src/wasm/wasm-module.h View 3 chunks +2 lines, -113 lines 0 comments Download
M src/wasm/wasm-module.cc View 33 chunks +210 lines, -137 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mircea Trofin
Created Revert of [wasm] Strongly typed compiled module
4 years, 2 months ago (2016-09-29 23:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383623003/1
4 years, 2 months ago (2016-09-29 23:26:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 23:26:56 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 23:27:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf2b4018189e1f437ac4b43bfeeef444b71186f2
Cr-Commit-Position: refs/heads/master@{#39893}

Powered by Google App Engine
This is Rietveld 408576698