third_party/WebKit/Source/bindings/scripts/code_generator_v8.py - Issue 2383613003: Remove 'V8' prefix from generated callback function classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

index 409c7b6d2c51bc9e9e9c0543b48e3703370cb99a..fa778f4b9b018dd7fd2c391aab0510eb3ee8ac0e 100644

--- a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

@@ -356,8 +356,8 @@ class CodeGeneratorCallbackFunction(CodeGeneratorBase):

template_context['code_generator'] = MODULE_PYNAME

header_text = header_template.render(template_context)

cpp_text = cpp_template.render(template_context)

- header_path = posixpath.join(self.output_dir, 'V8%s.h' % callback_function.name)

- cpp_path = posixpath.join(self.output_dir, 'V8%s.cpp' % callback_function.name)

+ header_path = posixpath.join(self.output_dir, '%s.h' % callback_function.name)

+ cpp_path = posixpath.join(self.output_dir, '%s.cpp' % callback_function.name)

return (

(header_path, header_text),

(cpp_path, cpp_text),