Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2383613002: Revert of [WASM] Implements catch for the wasm low level exception mechanism. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson, John
CC:
v8-reviews_googlegroups.com, v8-arm-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [WASM] Implements catch for the wasm low level exception mechanism. (patchset #16 id:300001 of https://codereview.chromium.org/2275293002/ ) Reason for revert: nosse4 errors: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/13524 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/11215 Original issue's description: > [WASM] Implements catch for the wasm low level exception mechanism. > > BUG= > > Committed: https://crrev.com/93e5425c46453764779bd557628d61fae670027a > Cr-Commit-Position: refs/heads/master@{#39881} TBR=titzer@chromium.org,bradnelson@chromium.org,jpp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5bb978461f16d458c96d28f0403af325afcabe59 Cr-Commit-Position: refs/heads/master@{#39884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -585 lines) Patch
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/compiler/wasm-compiler.h View 3 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 7 chunks +25 lines, -76 lines 0 comments Download
M src/frames.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-wasm.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/wasm/ast-decoder.cc View 14 chunks +43 lines, -102 lines 0 comments Download
M test/mjsunit/wasm/exceptions.js View 4 chunks +16 lines, -332 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [WASM] Implements catch for the wasm low level exception mechanism.
4 years, 2 months ago (2016-09-29 18:00:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383613002/1
4 years, 2 months ago (2016-09-29 18:00:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 18:00:38 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 18:01:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bb978461f16d458c96d28f0403af325afcabe59
Cr-Commit-Position: refs/heads/master@{#39884}

Powered by Google App Engine
This is Rietveld 408576698