MD Settings: Tests for URL navigation on load.

MD Settings: Tests for URL navigation on load.

BUG=637508

[michaelpg, 2016-09-30 04:07:04]

The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 04:07:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-09-30 04:07:49]

PTAL. I could land these tests with their associated CL
(https://codereview.chromium.org/2259163002) but there's a chance they're flaky.

[commit-bot: I haz the power, 2016-09-30 05:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 05:41:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-10-01 01:57:04]

The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 01:57:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 02:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 02:53:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-10-03 18:29:58]

lgtm

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_page_url_browsertest.js (right):

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_page_url_browsertest.js:20: var toolbar
= assert(document.querySelector('* /deep/ cr-toolbar'));
IIRC using /deep/ in a test is ok(?).

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_page_url_browsertest.js:57: // Resolves
the promise or schedules itself to run again in a rAF.
optional: 
// Resolves the promise or schedules itself to run again in a later
// animation frame.

Hmm, those (original and suggestion above) are both rather literal. Maybe drop
the comment?

[michaelpg, 2016-10-03 20:28:53]

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_page_url_browsertest.js (right):

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_page_url_browsertest.js:20: var toolbar
= assert(document.querySelector('* /deep/ cr-toolbar'));
On 2016/10/03 18:29:58, dschuyler wrote:
> IIRC using /deep/ in a test is ok(?).

yes: /deep/ inside querySelector is not deprecated, and it doesn't pose a
performance issue here

https://codereview.chromium.org/2383563004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_page_url_browsertest.js:57: // Resolves
the promise or schedules itself to run again in a rAF.
On 2016/10/03 18:29:58, dschuyler wrote:
> optional: 
> // Resolves the promise or schedules itself to run again in a later
> // animation frame.
> 
> Hmm, those (original and suggestion above) are both rather literal. Maybe drop
> the comment?

Done.

[michaelpg, 2016-10-04 01:35:24]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-10-04 01:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2383563004/#ps60001
(title: "comment")

[michaelpg, 2016-10-04 01:35:32]

k, let's see what breaks

[commit-bot: I haz the power, 2016-10-04 01:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 03:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:12:38]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[michaelpg, 2016-10-04 20:53:08]

This will be flaky until we can figure out a solution for the page size changing
during/after load:
https://bugs.chromium.org/p/chromium/issues/detail?id=637508#c9

[michaelpg, 2016-11-09 03:16:41]

Description was changed from

==========
MD Settings: Tests for URL navigation on load.

BUG=637508
R=dschuyler@chromium.org
==========

to

==========
MD Settings: Tests for URL navigation on load.

BUG=637508
R=dschuyler@chromium.org
==========

[michaelpg, 2016-11-09 03:16:41]

michaelpg@chromium.org changed reviewers:
- dschuyler@chromium.org

[michaelpg, 2016-11-09 03:16:55]

Description was changed from

==========
MD Settings: Tests for URL navigation on load.

BUG=637508
R=dschuyler@chromium.org
==========

to

==========
MD Settings: Tests for URL navigation on load.

BUG=637508
==========