Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2383553002: Only collect 1 stack trace when a test timeouts on mac (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 220d3ebc93085da57b18988a6a31c60e2c5c9389..5772e44bd50d39f78d8c7b52c682ad296f7fa165 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1870,8 +1870,11 @@ class RunningProcess {
});
} else if (io.Platform.isMacOS) {
// Try to print stack traces of the timed out process.
+ // `sample` is a sampling profiler but we ask it sample for 1
+ // second with a 4 second delay between samples so that we only
+ // sample the threads once.
io.Process.run('/usr/bin/sample',
- ['${process.pid}', '1', '1', '-mayDie'])
+ ['${process.pid}', '1', '4000', '-mayDie'])
.then((result) {
io.stdout.write(result.stdout);
io.stderr.write(result.stderr);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698