Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: src/mksnapshot.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Tiny serializer fix after recent changes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mksnapshot.cc
diff --git a/src/mksnapshot.cc b/src/mksnapshot.cc
index 47b5b3cda790fafa0ac217b2e81759b490939534..b436348750f3f22dd4fce8c13e0bf3ccaa00c3a1 100644
--- a/src/mksnapshot.cc
+++ b/src/mksnapshot.cc
@@ -271,6 +271,8 @@ void DumpException(Handle<Message> message) {
int main(int argc, char** argv) {
V8::InitializeICU();
+ // TODO(svenpanne) We can't do this here currently, although we should!
+ // v8::V8::Initialize();
i::Isolate::SetCrashIfDefaultIsolateInitialized();
// By default, log code create information in the snapshot.
@@ -410,6 +412,7 @@ int main(int argc, char** argv) {
ser.CurrentAllocationAddress(i::CELL_SPACE),
ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE));
isolate->Exit();
+ i::Serializer::TearDown();
isolate->Dispose();
V8::Dispose();
return 0;
« no previous file with comments | « src/isolate.cc ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698