src/api.cc - Issue 238353015: Simplify v8/Isolate teardown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased. Tiny serializer fix after recent changes. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 1530ff03f340a3206624d6ba99ee100a8fbe2002..fdfbff1c8e8ee3df0b5df0c721a62ce5f34eb294 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4995,12 +4995,6 @@ void v8::V8::SetArrayBufferAllocator(

bool v8::V8::Dispose() {

- i::Isolate* isolate = i::Isolate::Current();

- if (!Utils::ApiCheck(isolate != NULL && isolate->IsDefaultIsolate(),

- "v8::V8::Dispose()",

- "Use v8::Isolate::Dispose() for non-default isolate.")) {

- return false;

- }

i::V8::TearDown();

return true;

}

« no previous file with comments | « samples/shell.cc ('k') | src/d8.cc » ('j') | no next file with comments »