Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: test/cctest/cctest.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Tiny serializer fix after recent changes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 static void SuggestTestHarness(int tests) { 132 static void SuggestTestHarness(int tests) {
133 if (tests == 0) return; 133 if (tests == 0) return;
134 printf("Running multiple tests in sequence is deprecated and may cause " 134 printf("Running multiple tests in sequence is deprecated and may cause "
135 "bogus failure. Consider using tools/run-tests.py instead.\n"); 135 "bogus failure. Consider using tools/run-tests.py instead.\n");
136 } 136 }
137 137
138 138
139 int main(int argc, char* argv[]) { 139 int main(int argc, char* argv[]) {
140 v8::V8::InitializeICU(); 140 v8::V8::InitializeICU();
141 v8::V8::Initialize();
141 i::Isolate::SetCrashIfDefaultIsolateInitialized(); 142 i::Isolate::SetCrashIfDefaultIsolateInitialized();
142 143
143 v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true); 144 v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
144 145
145 CcTestArrayBufferAllocator array_buffer_allocator; 146 CcTestArrayBufferAllocator array_buffer_allocator;
146 v8::V8::SetArrayBufferAllocator(&array_buffer_allocator); 147 v8::V8::SetArrayBufferAllocator(&array_buffer_allocator);
147 148
148 i::PrintExtension print_extension; 149 i::PrintExtension print_extension;
149 v8::RegisterExtension(&print_extension); 150 v8::RegisterExtension(&print_extension);
150 i::ProfilerExtension profiler_extension; 151 i::ProfilerExtension profiler_extension;
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 } 200 }
200 if (print_run_count && tests_run != 1) 201 if (print_run_count && tests_run != 1)
201 printf("Ran %i tests.\n", tests_run); 202 printf("Ran %i tests.\n", tests_run);
202 CcTest::TearDown(); 203 CcTest::TearDown();
203 if (!disable_automatic_dispose_) v8::V8::Dispose(); 204 if (!disable_automatic_dispose_) v8::V8::Dispose();
204 return 0; 205 return 0;
205 } 206 }
206 207
207 RegisterThreadedTest *RegisterThreadedTest::first_ = NULL; 208 RegisterThreadedTest *RegisterThreadedTest::first_ = NULL;
208 int RegisterThreadedTest::count_ = 0; 209 int RegisterThreadedTest::count_ = 0;
OLDNEW
« no previous file with comments | « src/v8.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698