Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/mksnapshot.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Tiny serializer fix after recent changes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 fprintf(stderr, "%s\n", *message_line); 264 fprintf(stderr, "%s\n", *message_line);
265 for (int i = 0; i <= message->GetEndColumn(); ++i) { 265 for (int i = 0; i <= message->GetEndColumn(); ++i) {
266 fprintf(stderr, "%c", i < message->GetStartColumn() ? ' ' : '^'); 266 fprintf(stderr, "%c", i < message->GetStartColumn() ? ' ' : '^');
267 } 267 }
268 fprintf(stderr, "\n"); 268 fprintf(stderr, "\n");
269 } 269 }
270 270
271 271
272 int main(int argc, char** argv) { 272 int main(int argc, char** argv) {
273 V8::InitializeICU(); 273 V8::InitializeICU();
274 // TODO(svenpanne) We can't do this here currently, although we should!
275 // v8::V8::Initialize();
274 i::Isolate::SetCrashIfDefaultIsolateInitialized(); 276 i::Isolate::SetCrashIfDefaultIsolateInitialized();
275 277
276 // By default, log code create information in the snapshot. 278 // By default, log code create information in the snapshot.
277 i::FLAG_log_code = true; 279 i::FLAG_log_code = true;
278 280
279 #if V8_TARGET_ARCH_ARM 281 #if V8_TARGET_ARCH_ARM
280 // Printing flags on ARM requires knowing if we intend to enable 282 // Printing flags on ARM requires knowing if we intend to enable
281 // the serializer or not. 283 // the serializer or not.
282 v8::internal::CpuFeatures::SetHintCreatingSnapshot(); 284 v8::internal::CpuFeatures::SetHintCreatingSnapshot();
283 #endif 285 #endif
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 sink.WriteSpaceUsed( 405 sink.WriteSpaceUsed(
404 "", 406 "",
405 ser.CurrentAllocationAddress(i::NEW_SPACE), 407 ser.CurrentAllocationAddress(i::NEW_SPACE),
406 ser.CurrentAllocationAddress(i::OLD_POINTER_SPACE), 408 ser.CurrentAllocationAddress(i::OLD_POINTER_SPACE),
407 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE), 409 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE),
408 ser.CurrentAllocationAddress(i::CODE_SPACE), 410 ser.CurrentAllocationAddress(i::CODE_SPACE),
409 ser.CurrentAllocationAddress(i::MAP_SPACE), 411 ser.CurrentAllocationAddress(i::MAP_SPACE),
410 ser.CurrentAllocationAddress(i::CELL_SPACE), 412 ser.CurrentAllocationAddress(i::CELL_SPACE),
411 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE)); 413 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE));
412 isolate->Exit(); 414 isolate->Exit();
415 i::Serializer::TearDown();
413 isolate->Dispose(); 416 isolate->Dispose();
414 V8::Dispose(); 417 V8::Dispose();
415 return 0; 418 return 0;
416 } 419 }
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698