Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: src/isolate.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Tiny serializer fix after recent changes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 1544
1545 { LockGuard<Mutex> lock_guard(&process_wide_mutex_); 1545 { LockGuard<Mutex> lock_guard(&process_wide_mutex_);
1546 thread_data_table_->RemoveAllThreads(this); 1546 thread_data_table_->RemoveAllThreads(this);
1547 } 1547 }
1548 1548
1549 if (serialize_partial_snapshot_cache_ != NULL) { 1549 if (serialize_partial_snapshot_cache_ != NULL) {
1550 delete[] serialize_partial_snapshot_cache_; 1550 delete[] serialize_partial_snapshot_cache_;
1551 serialize_partial_snapshot_cache_ = NULL; 1551 serialize_partial_snapshot_cache_ = NULL;
1552 } 1552 }
1553 1553
1554 if (!IsDefaultIsolate()) { 1554 delete this;
1555 delete this;
1556 }
1557 1555
1558 // Restore the previous current isolate. 1556 // Restore the previous current isolate.
1559 SetIsolateThreadLocals(saved_isolate, saved_data); 1557 SetIsolateThreadLocals(saved_isolate, saved_data);
1560 } 1558 }
1561 1559
1562 1560
1563 void Isolate::GlobalTearDown() { 1561 void Isolate::GlobalTearDown() {
1564 delete thread_data_table_; 1562 delete thread_data_table_;
1565 } 1563 }
1566 1564
(...skipping 683 matching lines...) Expand 10 before | Expand all | Expand 10 after
2250 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map); 2248 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map);
2251 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8); 2249 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8);
2252 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert(); 2250 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert();
2253 } 2251 }
2254 } 2252 }
2255 return Handle<JSObject>::cast(factory()->symbol_registry()); 2253 return Handle<JSObject>::cast(factory()->symbol_registry());
2256 } 2254 }
2257 2255
2258 2256
2259 } } // namespace v8::internal 2257 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698