Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/mksnapshot.cc

Issue 238353015: Simplify v8/Isolate teardown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 fprintf(stderr, "%s\n", *message_line); 260 fprintf(stderr, "%s\n", *message_line);
261 for (int i = 0; i <= message->GetEndColumn(); ++i) { 261 for (int i = 0; i <= message->GetEndColumn(); ++i) {
262 fprintf(stderr, "%c", i < message->GetStartColumn() ? ' ' : '^'); 262 fprintf(stderr, "%c", i < message->GetStartColumn() ? ' ' : '^');
263 } 263 }
264 fprintf(stderr, "\n"); 264 fprintf(stderr, "\n");
265 } 265 }
266 266
267 267
268 int main(int argc, char** argv) { 268 int main(int argc, char** argv) {
269 V8::InitializeICU(); 269 V8::InitializeICU();
270 // TODO(svenpanne) We can't do this here currently, although we should!
271 // v8::V8::Initialize();
270 i::Isolate::SetCrashIfDefaultIsolateInitialized(); 272 i::Isolate::SetCrashIfDefaultIsolateInitialized();
271 273
272 // By default, log code create information in the snapshot. 274 // By default, log code create information in the snapshot.
273 i::FLAG_log_code = true; 275 i::FLAG_log_code = true;
274 276
275 // Print the usage if an error occurs when parsing the command line 277 // Print the usage if an error occurs when parsing the command line
276 // flags or if the help flag is set. 278 // flags or if the help flag is set.
277 int result = i::FlagList::SetFlagsFromCommandLine(&argc, argv, true); 279 int result = i::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
278 if (result > 0 || argc != 2 || i::FLAG_help) { 280 if (result > 0 || argc != 2 || i::FLAG_help) {
279 ::printf("Usage: %s [flag] ... outfile\n", argv[0]); 281 ::printf("Usage: %s [flag] ... outfile\n", argv[0]);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE), 399 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE),
398 ser.CurrentAllocationAddress(i::CODE_SPACE), 400 ser.CurrentAllocationAddress(i::CODE_SPACE),
399 ser.CurrentAllocationAddress(i::MAP_SPACE), 401 ser.CurrentAllocationAddress(i::MAP_SPACE),
400 ser.CurrentAllocationAddress(i::CELL_SPACE), 402 ser.CurrentAllocationAddress(i::CELL_SPACE),
401 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE)); 403 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE));
402 isolate->Exit(); 404 isolate->Exit();
403 isolate->Dispose(); 405 isolate->Dispose();
404 V8::Dispose(); 406 V8::Dispose();
405 return 0; 407 return 0;
406 } 408 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698