Simplify v8/Isolate teardown.

src/arm/assembler-arm.cc

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 85 matching lines @@
   if (index >= kDoubleRegZero.code())
     index += kNumReservedRegisters;
 
   return VFPRegisters::Name(index, true);
 }
 
 
 void CpuFeatures::Probe() {
   uint64_t standard_features = static_cast<unsigned>(
       OS::CpuFeaturesImpliedByPlatform()) | CpuFeaturesImpliedByCompiler();
-  ASSERT(supported_ == 0 || supported_ == standard_features);
+  ASSERT(supported_ == 0 ||
+         (supported_ & standard_features) == standard_features);

[jochen (gone - plz use gerrit), 2014/04/17 13:24:57]

unrelated?

[Sven Panne, 2014/04/22 07:28:36]

Alas, no: ARM has to be treated specially, which is quite unfortunate, but this
cleanup is better done in a separate CL. Furthermore, the ASSERT is more
correct: It makes sure that repeated Probe calls don't remove features.

 #ifdef DEBUG
   initialized_ = true;
 #endif
 
   // Get the features implied by the OS and the compiler settings. This is the
   // minimal set of features which is also alowed for generated code in the
   // snapshot.
   supported_ |= standard_features;
 
   if (Serializer::enabled()) {
@@ skipping 3619 matching lines @@
   ASSERT((index_64bit == count_of_64bit_) &&
          (index_code_ptr == (index_64bit + count_of_code_ptr_)) &&
          (index_heap_ptr == (index_code_ptr + count_of_heap_ptr_)) &&
          (index_32bit == (index_heap_ptr + count_of_32bit_)));
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM