Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2383523002: Fix obvious bug in KTX encoder. (Closed)

Created:
4 years, 2 months ago by dogben
Modified:
4 years, 2 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, weiqiangl_google.com
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/ktx/ktx.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
dogben
4 years, 2 months ago (2016-09-29 15:05:40 UTC) #7
msarett
Wow LGTM! Leon, do you know anything about the history of third_party/ktx? When was it ...
4 years, 2 months ago (2016-09-29 15:09:39 UTC) #9
msarett
Looks like we checked in (and maintain it) ourselves. Bug comes from the second CL. ...
4 years, 2 months ago (2016-09-29 15:14:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383523002/1
4 years, 2 months ago (2016-09-29 15:19:51 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:20:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b7394b9fbfc6f430dc0ee1c1e9505fe5c736838

Powered by Google App Engine
This is Rietveld 408576698