Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

Issue 2383503002: Measure usage of createObjectURL and srcObject (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "modules/mediasource/URLMediaSource.h" 31 #include "modules/mediasource/URLMediaSource.h"
32 32
33 #include "core/dom/DOMURL.h" 33 #include "core/dom/DOMURL.h"
34 #include "core/frame/UseCounter.h"
34 #include "modules/mediasource/MediaSource.h" 35 #include "modules/mediasource/MediaSource.h"
35 36
36 namespace blink { 37 namespace blink {
37 38
38 String URLMediaSource::createObjectURL(ExecutionContext* executionContext, Media Source* source) 39 String URLMediaSource::createObjectURL(ExecutionContext* executionContext, Media Source* source)
39 { 40 {
40 // Since WebWorkers cannot obtain MediaSource objects, we should be on the m ain thread. 41 // Since WebWorkers cannot obtain MediaSource objects, we should be on the m ain thread.
41 DCHECK(isMainThread()); 42 DCHECK(isMainThread());
43 DCHECK(executionContext);
hta - Chromium 2016/09/29 13:46:33 Since you're now DCHECKing (and, I think, crashing
foolip 2016/09/29 14:54:45 executionContext and source cannot be null here, a
44 DCHECK(source);
42 45
43 if (!executionContext) 46 UseCounter::count(executionContext, UseCounter::CreateObjectURLMediaSource);
44 return String();
45 return DOMURL::createPublicURL(executionContext, source); 47 return DOMURL::createPublicURL(executionContext, source);
46 } 48 }
47 49
48 } // namespace blink 50 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698