Android: cleanup jni_android to minimize external dependencies.

Android: cleanup jni_android to minimize external dependencies.

Other projects will be using the JNI bindings.
- Move GetMethodIDFromClassName down to content/browser/renderer_host/java,
the only place where it's used.
- Remove a few methods that are no longer in use.
- Trim down dependencies.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225471

[bulach, 2013-09-24 10:57:39]

joth: you're OWNERs everywhere. welcome back ;)
jochen: trivial changes in content/content_browser.gypi and
content/content_tests.gypi

[jochen (gone - plz use gerrit), 2013-09-24 10:59:46]

lgtm

[joth, 2013-09-24 13:31:49]

lgtm % namespace nits

https://codereview.chromium.org/23835020/diff/1/base/android/jni_android_unit...
File base/android/jni_android_unittest.cc (right):

https://codereview.chromium.org/23835020/diff/1/base/android/jni_android_unit...
base/android/jni_android_unittest.cc:32: namespace android {
nit: move to line 10. (normally more convenient to have the anon namespace code
nested inside the named namespace)

https://codereview.chromium.org/23835020/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/java/jni_helper.h (right):

https://codereview.chromium.org/23835020/diff/1/content/browser/renderer_host...
content/browser/renderer_host/java/jni_helper.h:9: 
content namespace

[bulach, 2013-09-24 14:43:34]

thanks joth! will land this after the downstream patch..

https://codereview.chromium.org/23835020/diff/1/base/android/jni_android_unit...
File base/android/jni_android_unittest.cc (right):

https://codereview.chromium.org/23835020/diff/1/base/android/jni_android_unit...
base/android/jni_android_unittest.cc:32: namespace android {
On 2013/09/24 13:31:49, joth wrote:
> nit: move to line 10. (normally more convenient to have the anon namespace
code
> nested inside the named namespace)

Done.

https://codereview.chromium.org/23835020/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/java/jni_helper.h (right):

https://codereview.chromium.org/23835020/diff/1/content/browser/renderer_host...
content/browser/renderer_host/java/jni_helper.h:9: 
On 2013/09/24 13:31:49, joth wrote:
> content namespace

Done.

[bulach, 2013-09-25 16:49:47]

+jam for trivial content/content_browser.gypi

[jam, 2013-09-25 19:11:09]

On 2013/09/25 16:49:47, bulach wrote:
> +jam for trivial content/content_browser.gypi

lgtm, please feel free to tbr other simple changes to gypi files in the future
(i.e. adding/removing files)

[commit-bot: I haz the power, 2013-09-26 08:16:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/23835020/13001

[bulach, 2013-09-26 08:25:49]

thanks jam, I'll TBR such changes in the future..

would you mind if I clarify this in the OWNERS file?
there was a message in chrome/OWNERS that got removed:
https://codereview.chromium.org/16452016/diff/5001/chrome/OWNERS

since the *.gypi was whitelisted...

perhaps we could either:
1) add that old message in content/OWNERS:
# If you just remove, rename, or add a file to a non-test gypi file,
# you can land that change TBR. Make sure to still add the people
# you're TBRing to the review thread and to send them email.

2) whitelist the *.gypi as in chrome
# per-file rules:
# These are for the common case of adding or renaming files. If you're doing
# structural changes, please get a review from a reviewer in this file.
per-file *.gypi=*


wdyt?

[commit-bot: I haz the power, 2013-09-26 10:45:50]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-26 10:49:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/23835020/13001

[commit-bot: I haz the power, 2013-09-26 17:01:07]

Change committed as 225471