Support URL fragment resolution againt non-hierarchical schemes

url/url_canon_relative.cc

Index: url/url_canon_relative.cc
diff --git a/url/url_canon_relative.cc b/url/url_canon_relative.cc
index 4edd6cedd68beed6d068fee1958ceae40929f1db..841bf259924367279dcdabe49d539be23319c779 100644
--- a/url/url_canon_relative.cc
+++ b/url/url_canon_relative.cc
@@ -100,11 +100,20 @@ bool DoIsRelativeURL(const char* base,
   // BUT: Just because we have a scheme, doesn't make it absolute.
   // "http:foo.html" is a relative URL with path "foo.html". If the scheme is
   // empty, we treat it as relative (":foo") like IE does.
-  url_parse::Component scheme;
-  if (!url_parse::ExtractScheme(url, url_len, &scheme) || scheme.len == 0) {
-    // Don't allow relative URLs if the base scheme doesn't support it.
-    if (!is_base_hierarchical)
+  url_parse::Parsed url_parsed;
+  url_parse::ParsePathURL(url, url_len, true, &url_parsed);

[brettw, 2013/11/20 00:03:51]

This codepath is called a lot and ParsePathURL and CountCharactersBefore aren't
super fast. Is there a way we can get what you need with less work?

[joth, 2013/11/21 00:08:45]

Done.

Reverted to the scheme lookup to as it was before (url_parse::ExtractScheme) and
looking for bare fragment by inspecting the first char of url for '#'

+  const url_parse::Component& scheme = url_parsed.scheme;
+  const bool scheme_is_empty = !scheme.is_nonempty();
+  if (scheme_is_empty) {
+    // No scheme. See if is a bare fragment.
+    if (url_parsed.ref.is_valid() &&
+        url_parsed.CountCharactersBefore(url_parse::Parsed::REF, true) ==
+        url_parsed.CountCharactersBefore(url_parse::Parsed::SCHEME, false)) {
+      // |url| is a bare fragement. This can be resolved against any base.
+    } else if (!is_base_hierarchical) {
+      // Don't allow relative URLs if the base scheme doesn't support it.
       return false;
+    }
 
     *relative_component = url_parse::MakeRange(begin, url_len);
     *is_relative = true;