Support URL fragment resolution againt non-hierarchical schemes

url/gurl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 #include "url/url_canon.h"
 #include "url/url_test_utils.h"
 
 // Some implementations of base/basictypes.h may define ARRAYSIZE.
@@ skipping 332 matching lines @@
     SetupReplacement(&GURL::Replacements::SetPath, &repl, cur.path);
     SetupReplacement(&GURL::Replacements::SetQuery, &repl, cur.query);
     SetupReplacement(&GURL::Replacements::SetRef, &repl, cur.ref);
     GURL output = url.ReplaceComponents(repl);
 
     EXPECT_EQ(replace_cases[i].expected, output.spec());
     EXPECT_EQ(output.SchemeIsFileSystem(), output.inner_url() != NULL);
   }
 }
 
+TEST(GURLTest, ClearFragmentOnDataUrl) {
+  // http://crbug.com/291747 - a data URL may legitimately have trailing
+  // whitespace in the spec after the ref is cleared. Test this does not trigger
+  // the url_parse::Parsed importing validation DCHECK in GURL.
+  GURL url(" data: one ? two # three ");
+
+  // By default the trailing whitespace will have been stripped.
+  EXPECT_EQ("data: one ? two # three", url.spec());
+  GURL::Replacements repl;
+  repl.ClearRef();
+  GURL url_no_ref = url.ReplaceComponents(repl);
+
+  EXPECT_EQ("data: one ? two ", url_no_ref.spec());
+
+  // Importing a parsed url via this constructor overload will retain trailing
+  // whitespace.
+  GURL import_url(url_no_ref.spec(),
+                  url_no_ref.parsed_for_possibly_invalid_spec(),
+                  url_no_ref.is_valid());
+  EXPECT_EQ(url_no_ref, import_url);
+  EXPECT_EQ(import_url.query(), " two ");
+

[brettw, 2013/11/20 00:03:51]

Nit: extra blank

[joth, 2013/11/21 00:08:45]

Done.

+}
+
 TEST(GURLTest, PathForRequest) {
   struct TestCase {
     const char* input;
     const char* expected;
     const char* inner_expected;
   } cases[] = {
     {"http://www.google.com", "/", NULL},
     {"http://www.google.com/", "/", NULL},
     {"http://www.google.com/foo/bar.html?baz=22", "/foo/bar.html?baz=22", NULL},
     {"http://www.google.com/foo/bar.html#ref", "/foo/bar.html", NULL},
@@ skipping 159 matching lines @@
 TEST(GURLTest, IsStandard) {
   GURL a("http:foo/bar");
   EXPECT_TRUE(a.IsStandard());
 
   GURL b("foo:bar/baz");
   EXPECT_FALSE(b.IsStandard());
 
   GURL c("foo://bar/baz");
   EXPECT_FALSE(c.IsStandard());
 }